Author Topic: Patch for latest protocoll change  (Read 5619 times)

Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Patch for latest protocoll change
« on: October 27, 2012, 19:09:17 »
In order to be able to support more audio formats, I had to change the server side protocoll (changes are backward compatible to clients build using the old protocoll).
Apply the patch on the server side, in order to use vompclient for raspberry pi.

Marten

Offline KarZan

  • Full Member
  • ***
  • Posts: 28
    • View Profile
Re: Patch for latest protocoll change
« Reply #1 on: December 17, 2012, 21:42:10 »
I tried this patch but could not compile after patching. Propably my version was wrong :) Is this patch in git?

Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Re: Patch for latest protocoll change
« Reply #2 on: December 18, 2012, 07:24:04 »
It is in git.

Offline iampivot

  • Jr. Member
  • **
  • Posts: 9
    • View Profile
    • Email
Re: Patch for latest protocoll change
« Reply #3 on: January 21, 2013, 06:32:34 »
I'm just trying out vomp on rpi, and applied this patch to the vdr-plugin-vompserver on my stock yavdr 5.0 installation. Before the patch I got

Protocoll mismatch s: 0 c: 200

now I get

Protocoll mismatch s: 100 c: 200

Is there a new patch somewhere that i need to apply to the server plugin?

Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Re: Patch for latest protocoll change
« Reply #4 on: January 21, 2013, 06:56:33 »
vompclient-raspi is now already on 0-4-0rc branch of the server, so you need to have the server on this git branch in order that they match.

Marten

Offline iampivot

  • Jr. Member
  • **
  • Posts: 9
    • View Profile
    • Email
Re: Patch for latest protocoll change
« Reply #5 on: January 21, 2013, 14:16:55 »
Ah right, didn't spot there was a more recent branch than master.

Offline laz

  • Full Member
  • ***
  • Posts: 31
    • View Profile
Re: Patch for latest protocoll change
« Reply #6 on: January 21, 2013, 17:09:29 »
The makefile I checked out from git yesterday tries to build the MVP client instead of the raspberry pi client by default. Lots of build errors until I spotted that one! I assume this happened during the merge.

N.B., the default branch for vompserver is not yet 0.4.0rc so you need to tell git to grab the correct vompserver version if you upgrade vompclient.

Offline JTe

  • Full Member
  • ***
  • Posts: 81
    • View Profile
Re: Patch for latest protocoll change
« Reply #7 on: January 22, 2013, 08:28:07 »
I just built the new server from 0-4-0rc and the latest Raspi vomp client and found out that the dvb subtitles stop working after about 10 to 15 minutes. Has anybody else found the same problem, or do I have something wrong with my build environment?

I did not have time to debug more, but it could be a memory leak, or a flag that is not turned off/on correctly?  I had to restart the whole client and then I will get the subtitles back again (for the next 10 to 15  minutes).


Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Re: Patch for latest protocoll change
« Reply #8 on: January 22, 2013, 08:33:48 »
We had to fix your patch since it was causing troubles on the mvp. (Clearing of the osd too often, and timer faulty due to global variable and not initialised clock at startup)
May be this introduced a new bug. (I only tested it for 1 minute), please feel free to find new bug. Probably a flag is not reset correctly.

Marten
« Last Edit: January 22, 2013, 08:35:25 by MartenR »

Offline JTe

  • Full Member
  • ***
  • Posts: 81
    • View Profile
Re: Patch for latest protocoll change
« Reply #9 on: January 22, 2013, 08:35:09 »
Ok, I will debug the new fixes.