Author Topic: Target MVP fails to compile  (Read 2309 times)

Offline hondansx

  • Full Member
  • ***
  • Posts: 169
    • ICQ Messenger - 178471580
    • View Profile
    • Email
Target MVP fails to compile
« on: November 07, 2012, 20:21:23 »
Hi,

don't know whether this is the right one, but no it compiles.

Code: [Select]
--- videomvp.h.orig 2012-11-07 21:17:54.337130080 +0100
+++ videomvp.h 2012-11-07 21:19:31.177881883 +0100
@@ -22,6 +22,7 @@
 
 
 #ifndef VIDEOMVP_H
+#endif
 #define VIDEOMVP_H
 
 // FIXME - check why so many things include unistd
@@ -110,7 +111,7 @@
 
     UCHAR getSupportedFormats() { return COMPOSITERGB | SVIDEO;};
     UINT supportedTVsize() { return ASPECT4X3|ASPECT16X9;};
-    UCHAR supportedTVFormats() { return 0;}; /* We cannot change this here
+    UCHAR supportedTVFormats() { return 0;}; // We cannot change this here
 
     int setFormat(UCHAR format);
     int setConnection(UCHAR connection);
@@ -156,4 +157,3 @@
     UINT mediapacket_len[WRITE_PACKETS];
 };
 
-#endif

GA-EP43 | headless | 1xCineS2 Dual | 1xSkystar 2.6D | VDR 1.7.37 
Frontend: 1xRasperry | 1xION3

Offline clausmuus

  • Full Member
  • ***
  • Posts: 125
    • View Profile
    • MLD
    • Email
Re: Target MVP fails to compile
« Reply #1 on: November 07, 2012, 21:44:04 »
Hi,

I have not check this, but in my mind, the "#endif" must be at the end of the document and it already exists there.

Claus
MLD - A Distribution also for the Raspberry PI

Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Re: Target MVP fails to compile
« Reply #2 on: November 08, 2012, 06:50:59 »
@hondansx
Thanks for the fix will go into git. But as clausmuus pointed out the endif is wrong.

Marten

Offline hondansx

  • Full Member
  • ***
  • Posts: 169
    • ICQ Messenger - 178471580
    • View Profile
    • Email
Re: Target MVP fails to compile
« Reply #3 on: November 08, 2012, 08:02:32 »
@hondansx
Thanks for the fix will go into git. But as clausmuus pointed out the endif is wrong.

Marten
This was intended, because I assume that the '#ifndef VIDEOMVP_H' is also wrong or not needed
.
GA-EP43 | headless | 1xCineS2 Dual | 1xSkystar 2.6D | VDR 1.7.37 
Frontend: 1xRasperry | 1xION3

Offline MartenR

  • Hero Member
  • *****
  • Posts: 789
    • View Profile
Re: Target MVP fails to compile
« Reply #4 on: November 08, 2012, 10:45:03 »
Quote
'#ifndef VIDEOMVP_H
is very important, it prevents that spurious compiler warnings occur, if you include a header file multiple times.

Marten