Media Player crash

[davep]

When playing MP3 files using the new media player (CVS plus the GUI patch) I can crash the client with 10% probability by either switching tracks using the up/down buttons or moving within a track with the << and >> buttons. The entire MVP crashes; the LED goes out and networking fails, so only a power-cycle will restore it.

The last couple of seconds of debug output is:

13:42:17.264076 [debug]  164 VDR - RR sleep - opcode 32
13:42:17.285571 [debug]  160 VDR - Rxd a response packet, requestID=85, len=51200
13:42:17.286622 [debug]  164 VDR - RR unsleep
13:42:17.287431 [debug]  164 doRequestResponse - got response 0x10244c28
13:42:18.034616 [debug]  164 VDR - RR sleep - opcode 32
13:42:18.056762 [debug]  160 VDR - Rxd a response packet, requestID=86, len=51200
13:42:18.057819 [debug]  164 VDR - RR unsleep
13:42:18.058874 [debug]  164 doRequestResponse - got response 0x10244c28
13:42:19.042058 [debug]  155 Remote - Button 30
13:42:19.042365 [debug]  155 VMediaView::handleCommand - cmd=30,p=0x10240580
13:42:19.042658 [debug]  155 AudioPlayer - new pos 1670776  skip 10s
13:42:19.051297 [debug]  164 AudioPlayer - Switch state from 1 to 3
13:42:19.052155 [debug]  164 Audio - MUTE MUTE MUTE
13:42:19.053052 [debug]  164 AudioPlayer - control feeder old=1, new=2

[avvdr]

@davep,
hmm - very strange - never saw before that vompclient was really able to crash the mvp.
Difficult to reproduce on my side (especially as I do not run the latest CVS currently).
Waht it does (from the debug output): It switches the feeder (audio feeder) from running to stop via afeed.stop(). Not sure whether something can go wrong there.
maybe it could help to call afeed.disable() before stop (at around line 114 in audioplayer.cc) :
{
afeed.disable();
afeed.stop();
}

Regards
Andreas

[davep]

That fixes it - 10 minutes of skipping music tracks with no problems at all.

Well done!