Loggytronic Forum

VOMP => VOMP for Raspberry Pi => Topic started by: JTe on December 07, 2012, 14:43:41

Title: Update e155f8b brakes dvb-subtitles
Post by: JTe on December 07, 2012, 14:43:41
I just updated to latest version and after applying the update e155f8b "Fix live TV ac3 playback, probably a very old bug" the dvb-subtitles do not show anymore!
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: MartenR on December 08, 2012, 09:40:48
Only live tv or also recordings?
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: MartenR on December 08, 2012, 10:47:17
Should be fixed now.
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: JTe on December 09, 2012, 21:39:22
I can confirm the subtitles are now working fine! At the same time I found a small problem with ArteHD subtitle clearing (the clear area is very small, and a small rounding error leaves some of the subtitle on the screen without clearing it). I made a quick dirty patch to roundup the error in all cases (patch attached). It seems to work, even it is not absolutely correct way to handle the problem (Should really add up the fractional parts (x + x-width & y + ywidth) and make rounding only then).
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: MartenR on December 10, 2012, 07:06:30
Thanks, in git now.
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: JTe on December 10, 2012, 08:25:40
Just one thing, does it matter if the area to be cleared crosses the drawable area, as it is now rounded up there is a possibility that r.x+r.w or r.y+r.h could cross the drawable area by a pixel? Is this a problem?
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: MartenR on December 10, 2012, 11:21:10
On the raspberry platform there should not be a problem, on the mvp I do not know.

Marten
Title: Re: Update e155f8b brakes dvb-subtitles
Post by: JTe on December 10, 2012, 13:38:21
Ok. I will check the code of the vomp platform when I have spare time.