Loggytronic Forum

VOMP => VOMP General / MVP => Topic started by: avvdr on March 14, 2007, 15:52:25

Title: Vomp media player
Post by: avvdr on March 14, 2007, 15:52:25
Hi all (esp. Chris),
I like vomp a lot - great work!
I use it now heavily and found it lacks media player functionality (anyway works much better then mediamvp oder mvpmc...).
So I started to work on adding media player functionality.
Currently I got the picture display working (was prio 1 for me). So I would like to share this with you - and to start discussion about some further work.
I've prepared the patches against todays cvs for client and server. Should I post them here? (about 150k).
- aa - they include WOL too (I use this heavily)...
@Chris: What do you think - would you like to integrate this into the project? I saw there is heavy progress in CVS - so I got my last snap about 2 weeks ago and I needed some time to merge everything...
I would be happy to put the staff into CVS...
Maybe some short Ideas about further work:
My prio 1 would be the audio (mp3) player - but I saw that there is ongoing work in the player area - so difficult to manage this.
I attach at least my readme that contains some descriptions and an overview about the functionality.

Regards
Andreas
Title: Re: Vomp media player
Post by: Harry on March 14, 2007, 16:20:36
your help to the project is greatly appreciated!
can't wait to see the results.
(but will wait patiently ;))

cheers!
Title: Re: Vomp media player
Post by: avvdr on March 14, 2007, 22:26:02
Hi all,
hmm - zipped patches are small enough - so I post them here.
If there is anybody out to try this...
Just apply the timer (see readme...) and _media patch (-p1) to the client sources, the server patch to the current cvs server part, check the makefile (still used -3 script for devenv).
I run the server on a Suse 10.2 - Suse vdr package (that is vdr-1.4.5-2.1) compiles against /usr/lib/vdr..
Maybe I will try to build a dongle out of it (not my major focus, I boot and mount from a DS101j NAS - so no real need for a dongle, the NFS works well for me).

Feedback is welcome...

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on March 15, 2007, 07:40:14
Hi avvdr,

yes, yes, yes.
How I would love to have this functionality already last Sunday, when my parents were visiting us and showing pictures of their last travel. This would have been a wow effect  ;D

Anyway, because of lack of time (family and work), I couldn't jump into working on the same functionality. But from time to time I can spend time to think how to do it.
The issue I see, is that JPEGs (i.e. the one from the newest cameras) are getting bigger and bigger. Sooner or later these will become so big that the memory at the MVP is getting the limiting factore. It may crash or not display the picture. Wifes won't accept this  ;)

So my idea would be to have the scaling as well as rotating on the server. This would have several benefits:
1. The memory in the MVP is no issue anymore, as the jpeg for the MVP is now already very small

2. Assuming the server is at least as fast as the MVP processor, the whole thing get's much faster, as at least the transfer through the network is then much faster. I assume everybody has a server at least as fast as the MVP. How to get tumbnails displayed on the MVP is horror I assume, just because of the network alone.

3. You could use the memory at the server for caching, let it be the thumbnail view or even the scaled pictures. If it is going to be perfect when it could even scale already the comming pictures, while you are currently watching on the MVP on.
Memory on the server is a no brainer for me, as it could use the hd as well for storing the thumbnails, etc.

4. You could easily integrate also EXIF information (i.e. rotation info). For sure you could do it on the MVP as well, but in case everygthing is on the server, the server could do it too.

I know this is against a idea of having everything done on the MVP, but for pictures I definetly see big advantages when we do the active part on the server.

Comments?
Title: Re: Vomp media player
Post by: Schnurps on March 15, 2007, 08:53:09
Good morning everybody,

I'm really looking forward having such a great mediaplayer-functionality on my mvp! :-)
The description of the picture-module sounds advanced and elaborate.
I would agree to muellerph - it seems to be be fastest way to pre-scale and pre-cache the pictures/thumbnails on the server. We must keep in mind the different resolutions of PAL/NTSC.

Chris mentioned i while ago that a problem of adding more and more media-functionality on the mvp is the limited space in the dongle/on the mvp - is this still critical?

Yours,
Schnurps
Title: Re: Vomp media player
Post by: MartenR on March 15, 2007, 18:57:17
QuoteChris mentioned i while ago that a problem of adding more and more media-functionality on the mvp is the limited space in the dongle/on the mvp - is this still critical?
Sure, this is still a problem, the people from mvpmc are currently at the limit and have problems to add more features.

Marten
Title: Re: Vomp media player
Post by: riban on March 15, 2007, 20:04:41
I remember Chris saying that there would be problems with resources in extending VOMP. I had the idea of making the various functions modular / plugin with the ability to download a plugin from a server. This way you could unload the MP3 player to load the Picture viewer. Of course we probably want music to accompany the pictures :-). I wrote a proof of concept MP3 player for the MVP which proved to be rather simpler than I expected. Just chucking an MP3 file at the dsp produces sounds and adding sending a second file straight after the first resulted in apparently seemless replay (e.g. two tracks from a continuous concept album).
I am frustrated at the moment because I can not compile the latest vompserver. I still use VDR 1.2.6 which the latest vompserver does not compile against. I would love to try out your code and am looking forward to being able to do so.
Title: Re: Vomp media player
Post by: muellerph on March 15, 2007, 20:27:52
Quote from: MartenR on March 15, 2007, 18:57:17
QuoteChris mentioned i while ago that a problem of adding more and more media-functionality on the mvp is the limited space in the dongle/on the mvp - is this still critical?
Sure, this is still a problem, the people from mvpmc are currently at the limit and have problems to add more features.
Yes, but they also have a huge functionality built into their software. For me they do much too much on the MVP.

They have a complete UPnP client. Also what I have seen so far is that they scale the pictures on the mvp (which I would avoid as stated above).
So they have lot's of libraries and are now facing the memory limits. Now they try to make it modular too as riban proposed.

I personally don't have the needs for a full UPnP client and all the other stuff they are doing - connecting to different kind of servers (mythtv, slimserver, flac, replaytv, etc.), having a VLC client built in, sshd support, ....
A simple way to display pictures and play sound directly from a VDR server is fine with me. I have no other media servers in my network and don't plan to do so.

A lean VOMP client with customized media functionality is enough for me. So in case we limit the functionality to customized VDR-Vomp-protocol, there should not be the same issue as mvpmc is having now.

But this is for sure only my requirement, others may also want these functionalities.
Title: Re: Vomp media player
Post by: avvdr on March 15, 2007, 20:58:08
Hi all,
OK - now I managed to build a dongle.
You can found all the files at http://www.wellenvogel.de/software/vomp/index.html (http://www.wellenvogel.de/software/vomp/index.html).

Some technical remarks:
1. thumbnails - not there until now - hmm they seem to be difficult to handle:
  - no big performance on server (VDR runs on small machines...)
  - lots of data to be transfered to the client if done there (and even perf issue)
  - maybe there is a way to extract embedded thumbnails from the JPEG (like e.g. xnview does) - would be about 6-20k per thumb
For me thumbs are not that important - I have my pictures sorted by month (and sometimes subdirs) - it would also be possible to create slide shows on the server e.g. by using links (hmm - didn't really handle softlinks well - probably they work but will get the time of the link..).
2. resources on the mvp: I tried to keep them low. I moved away from a complete buffer for the picture (jpeg lib allows for row based buffers). And I transfer the pics chunk by chunk (app. 256k each in the moment). So no real problem currently. After that I scale down during decompression (at max 8 - what jpeg lib allows) - this seems to be OK for our pics of 10MPx (Jpeg about 3.xxMBytes). - Disadvantage is that we don't have "smoother" scaling that better fits to the screen. But the needed computing power this way seem to remain nearly the same for 3MPx and 10MPx pictures (the 2 cameras we have).
From a quick look in the moment the transfer times are already at about 2s for big pics - this will be the first idea of an improvement (just put the transfer in a separate thread in parallel to decompress/draw). And here we could save time by a server based handling (I guess downscaling without real decompression would be fast). But maybe I could also find a solution for server based decompress and scale (anyway a decompressed image would still remain at > 1MB ->1s transfer...).
And the pixel drawing itself is not that fast (rest of the time) - the decompression seems to be quite fast. Maybe I will find some points to optimize this..
At the end the loading times are quite long in the moment (1-~4s) - but during a slide show this is not that big problem (from my point of view) - for navigation or rotation it's a bit annoing...

In any case I would like to get some feedback about the functions...

In the moment my major concern would be to get things integrated into CVS - otherwise it will become difficult to maintain the stuff (especially due to the changes in the surface handling - they go a little bit through many of the GUI classes).

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on March 15, 2007, 21:03:10
Your download site needs authorization with username and password at the moment
Title: Re: Vomp media player
Post by: avvdr on March 15, 2007, 21:12:58
after reading the thread - a lot of interesting ideas...
I will try to set up a list of things to do with prio.
@riban:
Could you send me your MP3 POC - maybe this way it would be fairly easy to at least create a first very basic mp3 player - just a new media handler view, a thread for getting the data ...
I'm not that familiar with MP3 - so if somebody knows a bit about it I would be interested in infos how to pic up the current playtime we are in (at the end I guess we should have all the great functions like time display, FF, B, skip,...) .

AA - authorization - forgot to upload the new .htaccess - should work now.

Andreas
Title: Vomp media player - Audio 1st step
Post by: avvdr on March 16, 2007, 19:39:40
Hello all,
after the interesting hints here, I just managed to also got a very basic audio player up and running.
You can find the downloads again at http://www.wellenvogel.de/software/vomp (http://www.wellenvogel.de/software/vomp).
Any feedback is highly welcome.

@chris:
Did you already think about integrating the stuff into cvs?

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on March 17, 2007, 00:28:34
Thanks, thanks, thanks.
I have just enjoyed now 2h sitting with my wide on the sofa and watching the photos from the server. No crash or similar things. Worked like a charm.

Thanks also for providing the binaries as well.
I have the C't installation and in order to use the binaries I had to update to Etch (which I wanted to do anyway). I know it's because of the new GCC version...

Performance:
I have pictures of a 1M and a 10M camera. For sure the 1M pictures were rather instantly available (1,5s) and the 10M needed 4-5s.

Just 1 thing at the moment:
Would be good in the file selection view directories could be differentiated easier than at the moment.
Title: Re: Vomp media player
Post by: avvdr on March 17, 2007, 09:51:32
Hi,
nice to here that it works...
@muellerph:
Do you have any suggestions how to improve the selection?
For me it works quite well - I'v got my photos orgnaized by a dir for each month (biggest has app. 850 photos).
Of course it would be helpfull to have thumbnails - but this will surely contradict the performance issue.
If anybody has some ideas how to improve selection based on the textual representation - I guess this could be implemented easily.

In the moment my prio list is like this:
1. make the audio player a little better (status display like recordings, faster stop responses,..)
2. make the audio player being "undockable" - i.e. put him in the background to be able to play music while watching photos
3. improve picture loading speed( separate thread, maybe at least prescaling on server)
4. colour mapping tunig - on my TV the colours are really shifted to red - (mainly for the OSD, not for the mpeg) - I guess this could depend on the factors when computing the colours...
...
n. watch mpg's
At least I gues I need some contact with Chris to discuss some of the player issues...

Regards
Andreas
Title: Re: Vomp media player
Post by: Chris on March 17, 2007, 16:50:47
avvdr ... I have sent you a large email to process :)
Title: Re: Vomp media player
Post by: muellerph on March 19, 2007, 07:50:40
Quote from: avvdr on March 17, 2007, 09:51:32
Do you have any suggestions how to improve the selection?
Not really much we can do about it. If you have 850 pictures in a directory, then beside of the filename there is not much more info available.
So either you do the organization manually by dividing into subdirectories or you have all in one. Even Thumbnails wouldn't help with 850 pictures (but would if it is on the range <100).
Exif may have additional info or maybe future cameras will include a GPS information as well. Using additional software with database integration (digikam, kimdaba) is not usable as well, as such info is not standardized.

As stated before I would propose to show directories in a different color and from sorting always on top. That's the only thing I'm missing.

Another general point:
You define in media which directories should be included.
E.g. /home/dude/myPictures.
The "ugly" point in the file selection is that this path is always displayed and if the path is long it doesn't really add info.
I would propose to have for each entry in media-section the path and a "name" which is then displayed as "root" for the path displayed. Or at least only display the last directory name.

Quote
Of course it would be helpfull to have thumbnails - but this will surely contradict the performance issue.
The thumbnail view should be optional. It's faster to find a special picture if you have a preview, but for sure if I want to see anyway a slideshow of the full directory this is definitely not needed.

Bug:
One tiny bug I found:
In case your path is not entered correctly in the media-section, then during display an error message is displayed. If you now press "back" then the display is broken but functional working. Just tiny as you only do the setup of the path once.

Feature requests:
1. Delete. It would be an easy way to delete the double pictures you made and only remain the best one. At least we do always 3-4 pictures of a scene and when we see the result on a big screen, just leave the best ones.
´
2. Exif orientation:
You can use the orientation stored in the EXIF info right from the beginning. No need for a full EXIF library just to do that. A code snippet how to read it can be found in following source file of mvpmc (http://git.mvpmc.org/cgi-bin/gitweb.cgi?p=mvpmc.git;a=blob_plain;h=02d4354c0cbbed802a9aa1478918a49fcbf61d00;f=libs/libwidget/image_jpeg.c): Just look into the function "get_exif_orient".
Title: Re: Vomp media player - new version MP3
Post by: avvdr on March 24, 2007, 09:26:34
Hi all,
today I finished a new version for the mediaplayer.
It fixes a couple of bugs (thanks to muellerph and Walt for finding them) and the audio player functions for playing MP3 including ID3 reading and VBR handling.
Also included is some improvde sorting in the media views (directories always on top) and marking dirs with [].
There is an important fix for the epgsettimer - that was broken in the last version.
This can be applied separately on top of the last patches.
Patches are still against CVS of 07/03/14.

Find the patches and dongle again at http://www.wellenvogel.de/software/vomp/index.html (http://www.wellenvogel.de/software/vomp/index.html).
Replies are welcome.

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on March 30, 2007, 14:20:04
Hello,

just loaded now the new dongle.
May you also provide the new vdrlib, otherwise the timer is still broken (at least here it is with just the new dongle).
I still don't have a vdr compilation environment (still trying to get my new computer booting linux - sata issue) and in case you have it anyway compiled would be cool to have it for us as well.

Music now works great. Just one thing: The ID3 tag recognition sometimes shows nothing. I assume there could be a check if the tag exists but has no content.

Thanks,

Philipp
Title: Re: Vomp media player
Post by: avvdr on March 30, 2007, 20:19:01
Hi Philipp,
strange ...
I didn't change the vdr lib - so it's still the same like last time (the timer correction was for the client).
The timer issue (on my site) was a pure crash -i .e. immediately when you try to set a timer from the epg vomp crashed.
Does this still happen?
Or is there any other issue?
I just double checked, but I'm quite sure that I used the right vompclient to build the dongle.

For the ID3 issue:
In general if noo ID3 is there there will only be the small display with file info and mpge info (if there).
For emtpy fields (album, artist) there is no special handling in the moment. For title I check for completely empty fields - it should display the filename in this case in the view headline.
The other things I could put on the list - maybe not prio 1.
My next step will be:
- rebase to new CVS (Chris made some changes in the timer handling Im going to test)
- improve image viewer (faster, more responsive, better scaling)
- "undock" audio player (+ playlists)
- mpg video player
Only my time is a little bit limited in the moment - spring is there - needs some outdor activities...

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on March 31, 2007, 10:04:29
Hi Andreas,

Quote from: avvdr on March 30, 2007, 20:19:01
The timer issue (on my site) was a pure crash -i .e. immediately when you try to set a timer from the epg vomp crashed.
Does this still happen?
Fixed :)

Quote
Or is there any other issue?
Yes. In the timerlist I can see all the timers existing but every name is just a "c", so the names are wrong.
Another one: As soon as I press OK on a timer in the list, the client crashes. Not that I use this option very often, but still a crash.

I'm also sure that I use the newest dongle you provided as within MP3 I can jump with 0-9.

Quote
For the ID3 issue:
In general if no ID3 is there there will only be the small display with file info and mpge info (if there).
Yes, I have seen that.
Quote
For empty fields (album, artist) there is no special handling in the moment.
That's what I meant with empty displaying.

QuoteFor title I check for completely empty fields - it should display the filename in this case in the view headline.
The other things I could put on the list - maybe not prio 1.
Yes not prio 1.

Cannot wait for the next features. And yes spring is also pressing me outdoor with the kiddies.
Title: Re: Vomp media player
Post by: avvdr on April 01, 2007, 07:45:44
Hi Phillip,
thanks for the intensive testing...
QuoteYes. In the timerlist I can see all the timers existing but every name is just a "c", so the names are wrong.
I cannot see this on mine.
Maybe I still need some more testing (but really didn't change things there...).
QuoteAnother one: As soon as I press OK on a timer in the list, the client crashes. Not that I use this option very often, but still a crash.
Fixed this and uploaded new patch + dongle at www.wellenvogel.de/software/vomp (http://www.wellenvogel.de/software/vomp)
Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on April 01, 2007, 09:44:38
Quote from: avvdr on April 01, 2007, 07:45:44
QuoteYes. In the timerlist I can see all the timers existing but every name is just a "c", so the names are wrong.
I cannot see this on mine.
Maybe I still need some more testing (but really didn't change things there...).
I have checked this in more detail.
It is not related to the dongle (I checked both) but to the libvdr. When I use the original libvdr-vompserver I get the normal names whichever dongle I use.
When I use your libvdr-vompserver then I have the "c", whichever dongle I use.
Quote
QuoteAnother one: As soon as I press OK on a timer in the list, the client crashes. Not that I use this option very often, but still a crash.
Fixed this and uploaded new patch + dongle at www.wellenvogel.de/software/vomp (http://www.wellenvogel.de/software/vomp)
Yes fixed ;)

Thanks,

Philipp
Title: Re: Vomp media player
Post by: hondansx on April 01, 2007, 10:56:59
Hi,

sounds really nice.
For testing I need the cvs code from 07/14/03 for the serverpart. Can anyone give me a hint how to get this code for this date?

Thanks
Walter
Title: Re: Vomp media player
Post by: riban on April 01, 2007, 15:57:30
To get vompserver from a specific date, use the -D option:

cvs -z3 -d:pserver:anonymous@vomp.cvs.sourceforge.net:/cvsroot/vomp co -D "14 March 2007"-P vompserver

(I assume 07/14/03 is supposed to be 14th March 2007!)

Walt
Title: Re: Vomp media player
Post by: hondansx on April 01, 2007, 20:01:35
@riban

Mercy that helped.
But now I can't compile:


make[1]: *** Keine Regel vorhanden, um das Target »tools.h«,
  benötigt von »media.o«, zu erstellen.  Schluss


Walter
Title: Re: Vomp media player
Post by: avvdr on April 02, 2007, 06:41:14
Hi Walter,
how do you compile?
At least you need the vdr inc/src.
Just check the Makefile for the VDRDIR/LIBDIR setting.
As mentioned I have Suse 10.2. with vdr installed, so VDRDIR is at /usr/include/vdr.
Normally if you have vdr src it points to your source dir.

Regards
Andreas

Title: Re: Vomp media player
Post by: avvdr on April 02, 2007, 06:46:54
@muellerph
Hi Philipp
QuoteI have checked this in more detail.
It is not related to the dongle (I checked both) but to the libvdr. When I use the original libvdr-vompserver I get the normal names whichever dongle I use.
When I use your libvdr-vompserver then I have the "c", whichever dongle I use.
I guess this is related to the cvs src just without mod's. Did you ever try without my patches applied?
I run against vdr 1.4.5 and it works (just double checked).
If I find some time I will try against 1.2.6 (but not sure if this compiles...).

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on April 02, 2007, 08:28:42
@Andreas,

I will check in more details - but will only be able to do it at the end of the week.

But as your libvdr is from SuSE and the original I have is from/for Etch, there maybe also other issues involved with dependecies on the distribution used. As stated before I now have Etch as system.

I have also had some random crashes when setting a timer, sometimes it worked sometimes vdr crashed (not the dongle).

As stated before, I first need to check it in more details before you start to investigate to much. Or someone else can confirm this behaviour.

Philipp
Title: Re: Vomp media player
Post by: hondansx on April 02, 2007, 18:50:40
@avvdr

It´s Debian Sarge and vdr sources.
I changed back the Makefile to:


VDRDIR = ../../..
LIBDIR = ../../lib


That should it be or may I am wrong ?

Regards Walter
Title: Re: Vomp media player
Post by: avvdr on April 02, 2007, 19:56:56
@Walter
QuoteVDRDIR = ../../..
LIBDIR = ../../lib
quite sure - plugin src should be at
.../PLUGINS/src/vompserver

Regards
Andreas
PS: What version of vdr do you use (just to know if it works...).
At least I found the 1.4.5 I have now much more stable then any previous one (already had vdr for a long time)
Title: Re: Vomp media player
Post by: hondansx on April 03, 2007, 19:24:32
@avvdr

it's 1.4.6 and same error as before.

Makefile

VDRDIR = ../../..
LIBDIR = ../../lib
TMPDIR = /tmp


make.sh

make VDRDIR=../../.. LIBDIR=../../lib PLUGINLIBDIR=../../lib $*


Where can I set the plugin src directory and is it necessary?

I don't understand what is wrong.
Can anybody enlighten me?

Walter
Title: Re: Vomp media player
Post by: avvdr on April 05, 2007, 18:38:59
Hi Walter,
strange...
When I remember things right with vdr src, you have to go to the vdr dir and call make plugins - this should do the job.
If I have some time (only next week) I will try again with the real vdr src.

Regards
Andreas
Title: Re: Vomp media player
Post by: hondansx on April 05, 2007, 19:03:28
Hi avvdr,

I did this for sure.
That would be great if you could do :-)

Thanks
Walter
Title: Re: Vomp media player
Post by: carsten on April 05, 2007, 20:47:09
Hi,

I can confirm that you need to call "make plugins" when compiling plugins, as it will besides other
things set some symbolic links for the includes includes e.g. the one you are missing: tools.h.

I didn't get what you meant by "I did this for sure". Did you mean you called make *plugins*?

You could also use e-tobi.net as repository and try that. That stuff is debianized.

Best Regards,
Carsten.
Title: Re: Vomp media player
Post by: hondansx on April 05, 2007, 21:13:38
@carsten

Sorry for my bad english.
I meant I did "make plugins".

Thanks for this interesting point ::):
Quote
things set some symbolic links for the includes includes e.g. the one you are missing: tools.h.

which helped me that it works now with this step  :D:

ln -s /usr/local/src/vdr-1.4.6/include/vdr/tools.h /usr/include


Now I can test this nice peace of code.
and thanks to avvdr.

Happy Eastern



Title: Re: Vomp media player
Post by: hondansx on April 06, 2007, 13:28:18
Hi,

sorry, now I get these errors if I build the dongle:


-O3 -Wall -Wshadow -Wno-format -Werror -D_GNU_SOURCE -I../jpeg/jpeg-6b   -c -o mark.o mark.cc
In file included from mark.cc:21:
mark.h:37: error: syntax error before `;' token
make: *** [mark.o] Error 1


In mark.h in line 37 I can see:

typedef vector<Mark*> MarkList;


What is the correct syntax?


Walter
Title: Re: Vomp media player
Post by: riban on April 07, 2007, 23:08:04
This is the script I use to build vompserver plugin:

grep VDR README>/dev/null 2>&1 && make all DVBDIR=/usr/include VDRDIR=/usr/include/vdr LIBDIR=. || echo "VDR not found in README so not building"

I move to the vompserver directory and run this script. I then copy the resulting libvdr-vompserver.so to the vdr plugin directory as libvdr-vompserver.so.1.2.6. (Note the suffix 1.2.6 corresponds to the vdr version.) On Debian Sarge this directory is /usr/lib/vdr/plugins.

Obviously changing DVBDIR and VDRDIR to where they are installed on your system.

Might not help but it is the way I get around using pre-compiled vdr. I don't remember the problem that prompted use of this script but it works. You may need to do a make clean first.

Walt
Title: Re: Vomp media player
Post by: avvdr on April 11, 2007, 22:57:52
Hi Walter,
QuoteIn file included from mark.cc:21:
mark.h:37: error: syntax error before `;' token
make: *** [mark.o] Error 1
-- hmm strange.
Have you been able to compile without the patches applied?
I guess you forgot to set the CROSS env variable - should be something like
export CROSS=/opt/crosstool/powerpc-405-linux-gnu/gcc-2.95.3-glibc-2.2.5/bin/powerpc-405-linux-gnu-


Regards
Andreas
Title: Re: Vomp media player
Post by: yymsc on April 18, 2007, 16:27:54
Hi,

when I boot my MVP with your dongle.bin, it does not accept any remote commands anymore. Any ideas what could be the reason for this?

thx,
Matthias
Title: Re: Vomp media player
Post by: torsten on April 20, 2007, 14:38:05
Hi,

Matthias' problem occurs on my box, too. I'm using vdr version 1.3.4x with a new remote. Even telnetting the box and starting the client with 'vompclient -d' didn't give me any hint to solve the problem.

BTW

@avvdr: Please separate your patches concerning OpenSUSE 's path structure from the rest. It would it make it much easier to get your patches to work.

Regards

Torsten
Title: Re: Vomp media player
Post by: avvdr on April 23, 2007, 06:19:28
Hi all,
have been away for some days...
2 answers:
Quotewhen I boot my MVP with your dongle.bin, it does not accept any remote commands anymore. Any ideas what could be the reason for this?
- I guess this is due to an rather old hauppauge dongle I used for creating the dongle. Try to switch to old remote - this could work.
See http://www.loggytronic.com/vomp-usage.php (http://www.loggytronic.com/vomp-usage.php) - configuration options how to switch.
I will try to build a new one (but need some time to do this). First I need to know which is the dongle version Chris uses... - does anybody know?

QuotePlease separate your patches concerning OpenSUSE 's path structure from the rest. It would it make it much easier to get your patches to work.
I will do this - but it's very simple - just 2 lines in the makefile with VDRDIR and LIBDIR.

Regards
Andreas
Title: Re: Vomp media player
Post by: yymsc on April 23, 2007, 10:06:27
Lucky me, I'm having an old remote too, and this is working.

thanks,
Matthias
Title: Re: Vomp media player
Post by: Kloana on May 09, 2007, 14:28:27
Hi avvdr, Hi Chris,

will this media client be implemented in the cvs repository, or do we have to patch the cvs, by our own?

I'm asking because i use the "Mahlzeit ISO 3.2", and I'm not very familiar with patching and compiling sources. ;-(

Thanks in advance,
regards
Herbert
Title: Re: Vomp media player
Post by: avvdr on May 10, 2007, 21:37:37
Hi Herbert,
Quotewill this media client be implemented in the cvs repository, or do we have to patch the cvs, by our own?
I guess finally this has to be answered by Chris.
At the end there is still some work to be done (so I have to rwrite some of the things to make it easier to fit into the current cvs).
In the mean time you can try out the compiled dongle.
Hopefully I will be able to provide new patches + dongle basing on the current cvs soon.

Regards
Andreas
Title: Re: Vomp media player
Post by: avvdr on May 13, 2007, 20:07:24
Hi all,
I just rebased the mediaplayer to the current cvs (client side) as of 07/05/12.
Additionally it is made with makedevenv-5 - so the newest modules are used, this could potentially fix some problems with the new remote.
The files are available at http://www.wellenvogel.de/software/vomp/index.html (http://www.wellenvogel.de/software/vomp/index.html).
No new functionality, just internal rewriting and newest version.
@Chris: I rebased everything to work without dynamic surfaces.
The attached tgz contains separated patches for changes at base, wjpeg and additional files.
The changes at the base classes now are:

Testing and replies are welcome...
Regards
Andreas
Title: Re: Vomp media player
Post by: Kloana on May 14, 2007, 07:53:06
Hi,

i'm currently working with the vomp server plugin 0.2.7. No patch and no diff applied. Can i use your compiled vomp-dongle with this server plugin, and it will work, or do i have to upgrade also the server plugin?

Thanks in advance,
regards
Herbert
Title: Re: Vomp media player
Post by: avvdr on May 14, 2007, 08:25:51
Hi Herbert,
sorry - you need to patch the server side too.
The media player needs some new functions there.
Just pick up the server side patches from this thread or from http://www.wellenvogel.de/software/vomp/patch_server_070314_media.txt.gz (http://www.wellenvogel.de/software/vomp/patch_server_070314_media.txt.gz).
See the desription in readme_media.txt for setting up the configuration on the server side.

Regards
Andreas
Title: Re: Vomp media player
Post by: Kloana on May 14, 2007, 08:56:21
Hi,

shit, this is my problem,... ;-( I'm not so familiar with Linux.

Thanks
regards
Herbert
Title: Re: Vomp media player
Post by: avvdr on May 14, 2007, 09:25:12
Hi Herbert,
maybe not that difficult...
Which vdr version do you run on ?
typically simply downloading src , patch and compile.
Maybe I can give you some support...

Regards
Andreas
Title: Vomp media player - servr part current cvs
Post by: avvdr on May 15, 2007, 22:01:15
Today I rebased the server part to the current cvs (2007/05/15).
I uploaded the patches to http://www.wellenvogel.de/software/vomp/index.html#2007_05_15 (http://www.wellenvogel.de/software/vomp/index.html#2007_05_15).
This patches do not modify the VDRDIR/LIBDIR in the Makefile - so compiling should be easier.
See the hints for compiling if you have vdr as a package (like e.g. on Suse 10.2.).
The splitted version of the patch is attached, just apply all included patches with -p1 to the server sources.

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on May 16, 2007, 15:02:46
Hello Andreas,

I didn't try the new code yet.
This is mostly because of your comment stating: "Because of the new key mapping I had to stop both vdr and vomp, delete the 00-xx-xx..conf file and restart both."

If I understand this correctly it means that I cannot switch anymore between the plugin and dongle of the official release and this test versions anymore.

Is my assumption correct?
Title: Re: Vomp media player
Post by: avvdr on May 17, 2007, 05:58:35
Hi Philipp,
QuoteIf I understand this correctly it means that I cannot switch anymore between the plugin and dongle of the official release and this test versions anymore.

I don't think so. Only when I start using the new dongle I had some problems with the keys.
So you should simply try...
An easy solution would be to backup the 00-xx-xx..conf before (mv 00-xx-xx..conf 00-xx-xx..conf.ori or so) - try/play and if something goes wrong you still have the copy.
Low risk...
Finally we have to ask Chris if there are issues with the learning key mapping.

Regards
Andreas
Title: Re: Vomp media player
Post by: MartenR on May 17, 2007, 11:52:03
If the abstract remote commands are used inside your code like in the GUI code of vomp, you should not to have to change anything inside your code for the new remote commands. The whole command translation occurs inside the remote class. However not all commands have assigned keys at the beginning, only commands used by the vomp code. So it might be that for a command you use no key is mapped in the beginning.

Marten
Title: Re: Vomp media player
Post by: Bandit2001 on May 24, 2007, 21:56:33
Hi all,

great job you have done here!
I'm running LinVDR (vdr-1.4.5), but unfortunately i have no development environment installed.
I tried your pre-compiled vompserver and dongle, but there are some libs missing. I tried to install them, but i did not manage all:


linvdr:/usr/lib/vdr/plugins# ldd libvdr-vompserver.so.1.4.5
./libvdr-vompserver.so.1.4.5: /usr/lib/libstdc++.so.6: no version information available (required by ./libvdr-vompserver.so.1.4.5)
./libvdr-vompserver.so.1.4.5: /usr/lib/libstdc++.so.6: no version information available (required by ./libvdr-vompserver.so.1.4.5)
./libvdr-vompserver.so.1.4.5: /lib/libc.so.6: version `GLIBC_2.3.2' not found (required by ./libvdr-vompserver.so.1.4.5)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0xb7f0f000)
        libm.so.6 => /lib/libm.so.6 (0xb7eee000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0xb7ee5000)
        libc.so.6 => /lib/libc.so.6 (0xb7dc8000)
        /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x80000000)
linvdr:/usr/lib/vdr/plugins#


Can anyone help me please, I don't know what to do!  ???
Title: Re: Vomp media player
Post by: Harry on May 25, 2007, 07:51:53
hmm..

ldd's error text tells me that you do have those libraries, but no
(or not the needed) version information could be retrieved from them.

so apparently, the binary, you're trying to run, is incompatible with the installed
libs.
i could be mistaken, for this isn't exaclty my field, but i would suggest
compiling vompserver on and for your special type of distro.
isn't there a compiler available for yours?
what does a
strings /usr/lib/libstdc++.so.6 | grep -i GLIBC
give you?

cheers
Harry
Title: Re: Vomp media player
Post by: muellerph on May 25, 2007, 12:44:34
No need to try something.

LinVDR is incompatible with this library.

The library is for Suse 10.something.

Suse uses already the GCC 4.something while linvdr use a 3.something.

Between the version, the c++ bindings have changed. It is known to be incompatible.
So no way to use it directly. And the library where you get the error exactly states that it is a c++ library (/usr/lib/libstdc++.so.6)

Either upgrade your installation or compile the library on your own.

I had the same issue, when I was using C't Vdr 4.5 which is sarge based. After uprading to Etch this issue was solved.
Title: Re: Vomp media player
Post by: Bandit2001 on May 25, 2007, 17:00:37
Quote from: muellerph on May 25, 2007, 12:44:34
Either upgrade your installation or compile the library on your own.

Well, I do not want an upgrade, because my system is running fine at the moment.

But I'll try to install VM on Windows an compile it there.
Title: Re: Vomp media player
Post by: ulbr2000 on May 26, 2007, 07:31:55
Hello Andreas,

I tried to implement the latest update 2007/07/15 and have several issues:
1. Patching
which is the correct order of patching or is the order not relevant?
I get following messages for "patch-server-media-cvs070515-070515.txt":
Reversed (or previously applied) patch detected!  Assume -R? [n]


2. Loading media
The connection to the server is lost loading the media list.

VDR log shows the following failure:
ERROR: plugin '<no name given>' called cPlugin::ConfigDirectory(), which is not thread safe!


I am using vdr 1.4.7 on SUSE 10.1

regards
Title: Re: Vomp media player
Post by: avvdr on May 29, 2007, 06:18:02
Hi,
hmm - looks strange.
Quote1. Patching
which is the correct order of patching or is the order not relevant?
I get following messages for "patch-server-media-cvs070515-070515.txt":
Reversed (or previously applied) patch detected!  Assume -R? [n]
How did you apply the patches?
normal doing would be:
cvs -z3 -d:pserver:anonymous@vomp.cvs.sourceforge.net:/cvsroot/vomp co  -P vompserver
cd vompserver
patch -p1 < ../patch-server-media-cvs070515-070515.txt

Maybe you can add -D 2007/05/15 after the co in the cvs command (but it worked with the current cvs).
Quote2. Loading media
The connection to the server is lost loading the media list.

VDR log shows the following failure:
ERROR: plugin '<no name given>' called cPlugin::ConfigDirectory(), which is not thread safe!
So did you patch the vompserver plugin finally and compiled it?
Otherwise it's no surprise, that loading the media list will lead to a connection lost - the unpatched plugin does not understand the command and will not answer.
The error you see seems to be normal (always get this).

Regards
Andreas
Title: Re: Vomp media player
Post by: ulbr2000 on May 29, 2007, 16:52:04
Hi Andreas,

which patch needs to be applied? For me this is not clear loooking at your homepage:

is it the one file from
    * patch-server-media-cvs070515-070515.txt.gz

or the two files from
    * patch-server-media-split-cvs070515-070515.tgz

or all 3 files?

I assume, it's the first one only, please confirm.

But when I apply the patch from the first file then vompserver does not compile with vdr-1.4.7:

mvpclient.c: In member function 'int MVPClient::processGetImageBlock(unsigned char*, int)':
mvpclient.c:2108: warning: comparison between signed and unsigned integer expressions


The cvs without the patch compiles fine

any ideas?

regards
Title: Re: Vomp media player
Post by: avvdr on May 29, 2007, 22:11:22
Hi,
QuoteI assume, it's the first one only, please confirm.
The first one is OK, the "splitted" contains the same changes but separated into 2 files
QuoteBut when I apply the patch from the first file then vompserver does not compile with vdr-1.4.7:
so they made compiling stricter in 1.4.7..
Please try changing line 2108 into
if (position != (ULLONG)ftell(imageFile)) {

I don't have 1.4.7. - can you just post the CXXFLAGS from Make.config - I would try with them.
If the change works, I will include it into the next patch.

Regards
Andreas
Title: Re: Vomp media player
Post by: ulbr2000 on May 30, 2007, 16:39:30
Hi Andreas

I've changed line 2108 in mvpclient.c but again it does not compile:

make[1]: *** No rule to make target `tools.h', needed by `media.o'.  Stop.
make[1]: Leaving directory `/usr/local/src/vdr-1.4.7a/PLUGINS/src/vompserver-0.2.7'

maybe an error in the patch for media.c, line 53?

+#include "tools.h"  <--- should read +#include "vdr/tools.h" ?

I changed above line (inserted the vdr/) and now it compiles...

AND WORKS

I do not have a Make.config, only a Makefile in the VDR-main directory and there are more CXXFLAGS-lines in there.
Which one do you need?

regards

PS: I would love to see playlist-support (e.g.m3u as in Winamp   ;D )

PPS: MP3 files with a rate of 320kbps are stuttering at playback. 256kbps is ok
Title: Re: Vomp media player
Post by: Chris on July 15, 2007, 18:25:05
Andreas, all:

The media player code is now in CVS. My most humble apologies for it taking so long.  :o

Thank you very much Andreas for your efforts, it looks like it will be an excellent addition to vomp.
Title: Re: Vomp media player
Post by: davep on July 15, 2007, 21:13:36
Brilliant!

Just updated from CVS onto my VDR 1.5.4 installation (with the patch I posted a couple of weeks ago) and it's working! Maybe I got something wrong in the vomp.conf file because I get to see the root directory of my server, and the jpeg viewer doesn't like some images which have been cropped by the GIMP, but it's still an excellent addition to the project.

Andreas, many thanks.

Dave
Title: Re: Vomp media player
Post by: avvdr on July 18, 2007, 18:22:25
Chris:
Glad to here that it is in CVS now...
In the moment there is not much time on my side - but I will continue to work on it (at least during winter time...)
If you still remember back my mail - it would be helpfull to have an idea for a "hidden" view to make drawing the new picture possible in background (this would keep the picture viewer responsive during loading).
QuoteAs an alternative I was thinking of moving the view outside the visible screen (I made some tries and this seemed to work - but it's a bit dirty and I would not like it). Maybe you have some idea for this...

@davep:
you should add something like:
[Media]
  Dir.1=/home/Andreas/pictest
  Dir.2=/home/video
  Dir.3=/home/bilder
  Dir.4=/media
to the vomp.conf (refer to readme_media.txt) - if nothing is configured, it defaults to /.
Have you got an example of a non working jpeg (at the end I'm afraid that I cannot do much - it depends on the jpeg lib...).

Regards
Andreas
Title: Re: Vomp media player
Post by: davep on July 18, 2007, 21:04:52
Quote from: avvdr on July 18, 2007, 18:22:25
you should add something like:
[Media]
  Dir.1=/home/Andreas/pictest
  Dir.2=/home/video
  Dir.3=/home/bilder
  Dir.4=/media
to the vomp.conf (refer to readme_media.txt) - if nothing is configured, it defaults to /.

The active configuration file on my system is called vomp-00-0D-FE-00-16-FE.conf - this is the file which is updated when configuration changes are made, and that's where I originally put the [Media] section. However I've since discovered that the multimedia directories are actually read from vomp.conf  :-\

Dave
Title: Re: Vomp media player
Post by: avvdr on July 19, 2007, 09:32:41
OK - this was intentionally - the vom-<any-mac>.conf is for each particular vomp client, whereas the vomp.conf is related to all vomp's connected to this server. And I felt, that the media directories more belong to the server then to one particular client...

Regards
Andreas
Title: Re: Vomp media player
Post by: hondansx on July 19, 2007, 12:19:03
Would be nice, if Chris could take this into CVS for the vomp.conf.sample.

Bye
Alex
Title: Re: Vomp media player
Post by: riban on August 19, 2007, 20:36:00
Hi

Just compiled vompserver from cvs to get the media player working. Good work.

Have you considered providing exif orientation support as suggested earlier in this thread (http://www.loggytronic.com/forum/index.php?PHPSESSID=9kamvi4g78gns6rhg2vjhl4ff7&topic=248.msg1473#msg1473 (http://www.loggytronic.com/forum/index.php?PHPSESSID=9kamvi4g78gns6rhg2vjhl4ff7&topic=248.msg1473#msg1473))?

This would make it so much better. We have been getting neck ache, looking at half our pictures at 90 degrees! Also, the pictures all come out rather small (probably only using half the available screen real estate) and have the wrong aspect ratio. I forced my widescreen TV to 4:3 which improved things but I don't think this fixed it completely and it would be better if the picture viewer accounted for aspect ratio.

Is there a way of getting it to traverse directories? Currently it sits on one directory and loops. This is true for both audio and pictures. I would like to be able to say, "play all files in all subdirectories of this one".

Also, could the pause button resume play back from pause (that is press pause button to pause playback then press pause button (or play button) to resume playback)?

And another thing: any chance of a random play option?

Sorry for the long list of feature requests and feedback. I just want it even better.

Cheers

Walt
Title: Re: Vomp media player
Post by: Uatschitchun on August 20, 2007, 17:37:40
Just stumbled across this great great new feature!

The missing media-playback was the only drawback that keeps me from using vompserver ;)

If movie-playback will come, too (would be cool if even server-side recoding of other formats than mpeg is possible) I have no wishes left!

Big thx for this  ;D

Lg
Roman
Title: Re: Vomp media player
Post by: avvdr on August 27, 2007, 16:42:30
Hi all,
been out for a while, some answers here:
@riban:
QuoteHave you considered providing exif orientation support as suggested earlier in this thread
Yes it's on my list (still needs to become autumn or winter...).
QuoteAlso, the pictures all come out rather small (probably only using half the available screen real estate) and have the wrong aspect ratio.
Hmm - could you describe this in more detail and give an example?
I try to keep the aspect. In the moment I can only scale by 1/2,1/4,1/8 - so I would allow 10% being cropped if too big - otherwise I use the next fitting scale. I would need either some server side preprocessing or an adapted libjpeg  :(.
QuoteIs there a way of getting it to traverse directories
OK - have to think about
QuoteAlso, could the pause button resume play back from pause
For audio it should work like this, have to check for the picture viewer.
QuoteAnd another thing: any chance of a random play option?
You can use the blue button to change the sort order - it traverses trough name,time,random - things will be played like this...
@Uatschitchun:
movie playback is also one of my prio 1 items...
Other server side formats - no chance to do this via vomp. But at least I think about options for playing them (will need server side conversion).

Regards
Andreas
Title: Re: Vomp media player
Post by: riban on September 02, 2007, 22:53:54
Hi Andreas

Thanks for the response. I have done some further investigation and describe the results below. I am currently using cvs snapshot from 22nd July 2007.

Pressing pause button when audio or pictures are paused does not resume playback.

Using blue button to change replay order works (thanks) but the indication on the screen gets out of step (e.g. display 'Name' but actually sorted / replaying randomly).

The information display for audio playback shows this:

    MpegInfo: MPEG 1/L3 CBR, SR=44k, Joint Stero

Note the spelling mistake, should say Stereo.

Could the sample rate be shown as 44.1kHz?

Could the MpegInfo say something like Coding Info or Algorithm Info?

The buffering of the audio data causes some actions to be delayed (e.g. Fast forward). There are other cases where Vomp suffers this (e.g. aspect ratio signal changes). Is there any way of working around this? Maybe flushing buffers or using smaller ones?

Examples of problems with image size:

All images are stretched horizontally when displayed on a wide screen TV with aspect ratio set to 16:9. This is what my TV detects from the mvp in my setup.

An image of size 1280 x 1600 pixels is shown scaled to 1/4. This appears 23cm high on a screen with 32cm available height.

An image of size 1600 x 1280 pixels is shown scaled to 1/2. This fills the screen real estate. When the TV is forced to 4:3 aspect ratio, the image is slightly distorted. There should be space at the sides but there is not. Does your code crop the image at all?

An image of size 3456 x 2304 pixels is shown scaled to 1/8. This appears 16cm high on the same screen (32cm height available). It appears 28cm wide (4:3 aspect) with 43cm available screen. (It appears 38cm wide in 16:9 aspect with 57cm available screen.)

I hope there is sufficient detail here to help you. I understand the seasonal thing. I have just got back from camping and feel much better for having been away from this thing (computer).

Cheers

Walt
Title: Re: Vomp media player
Post by: rdoac on September 06, 2007, 17:11:15
Hey guys, I just stumbled across this today, I had been running a dongle from cvs for a few weeks but only just noticed the media option then read up in this thread how to get it working.  I now have my photos and mp3 working.  Again I would agree that avi playback would be perfect and would recommend using mencoder to recode on the fly similar to how vlc "works" on a dreambox.  I use mencoder to recode a TS stream with streamdev to watch my sat tv on a laptop when I am away from home.  If it can encode to divx then it will encode to mpeg 2 for the vomp. Have a look at extern.sh in /usr/share/vdr/streamdev (if you haven't already).

As an aside, does anyone have a newer windows clilent compiled with the features, I use a laptop in our bedroom to watch TV and it would be wonderful to have the same functionality.
Title: Re: Vomp media player
Post by: mentox on September 06, 2007, 23:19:24
Hi,

works great from cvs. Thanks for this good work !!!

i have miss mp3 support at first time :-)


is it possible to play a folder completly or at this moment only file by file ?


thanks and greetings mentox
Title: Re: Vomp media player
Post by: hondansx on September 08, 2007, 09:58:00
is it possible to play a folder completly or at this moment only file by file ?

No
Title: Re: Vomp media player
Post by: Harry on September 08, 2007, 22:09:16
Quote from: avvdr on July 19, 2007, 09:32:41
OK - this was intentionally - the vom-<any-mac>.conf is for each particular vomp client, whereas the vomp.conf is related to all vomp's connected to this server. And I felt, that the media directories more belong to the server then to one particular client...

i disagree.
if you have more than one MVP in different households (that's my case)
you'll wish for the feature to store [Media] sections in individual *.conf files.

cheers,
Harry
Title: Re: Vomp media player
Post by: muellerph on September 09, 2007, 13:54:08
The 2 conf files are fine and perfectly works as they should. What is missing is a 3rd conf file.

1. Server-conf. This file is by server and represents what is used for every client (like which dongle to use)
2. Client-conf: This represents what the MVP setup is, like tone

3. (Missing) Group-conf: As soon as we have userprofiles, such a conf file is missing. This file would still be used by every client, but stores config which should be used for different users/groups.

My setup is: 1. client in living room 2. client in parents sleeping room. x clients in childrenrooms (not yet established, but will be when children a old enough)

Now I and my wife would like to see every TV program or functionality, while I would limit (nothing new) the time and programs for my children.

Non of these make sense to store in the serverconfig or clientconfig, as the living room TV is used by every "user". So it needs to be stored in a separate config.

But we still don't have a user profile, so this needs to be implemented first.
With this you will get this additional config automatically and then it will be easy to implement the config there as well.
Title: Re: Vomp media player
Post by: Harry on September 09, 2007, 14:46:37
i'm not questioning the *.conf file theme in any way
but was only referring to where to put the [Media] section.

userprofiles?
... you wanna make users "log on" to the MVP?
seems a bit far-fetched...
but this is not what this thread is about, anyway.

cheers
Harry
Title: Re: Vomp media player
Post by: rdoac on September 10, 2007, 07:42:47
Quote from: hondansx on September 08, 2007, 09:58:00
is it possible to play a folder completly or at this moment only file by file ?

No

Are you sure, when displaying all the mp3's in the folder, if I click on the first in the list with the play button in instead of the OK/Select button it plays the entire directory (and then loops it and does it again..)

My only concern would be if there was a way to stop the looping, but I am a happy man.
Title: Re: Vomp media player
Post by: MartenR on September 15, 2007, 12:14:54
I am now starting to think about how to port the mp3 part to windows.
Can you please tell me how the mp3 data are passed to the draintarget?
Are they passed one PES packet after another or does the code not care about the paket structure (hopefully not)?

I think is easier to ask instead of understanding demuxeraudio in detail.

Marten
Title: Re: Vomp media player
Post by: toxic-tonic on September 25, 2007, 08:32:24
Hi,

today I tried to patch an actual cvs-shot with the patches from here: http://www.wellenvogel.de/software/vomp/index.html

Unfortunatelly there where many rejects, to much for me to fix it by hand. Is there a newer patch anywhere or could anyone tell me
where to get the cvs-version witch works with this patch?

Thx

Toxic
Title: Re: Vomp media player
Post by: muellerph on September 25, 2007, 08:40:39
Quote from: toxic-tonic on September 25, 2007, 08:32:24
today I tried to patch an actual cvs-shot with the patches from here: http://www.wellenvogel.de/software/vomp/index.html
It is already in CVS. No need to patch anymore.
Title: Re: Vomp media player
Post by: toxic-tonic on September 25, 2007, 09:03:55
And the Dongle? The last from the Site above?
Title: Re: Vomp media player
Post by: hondansx on September 25, 2007, 11:38:13
Hi,

you can take this one.

http://www.speedyshare.com/671386800.html
(http://www.speedyshare.com/671386800.html)
as described here

http://www.vdr-portal.de/board/thread.php?threadid=68215&threadview=0&hilight=&hilightuser=0&sid=2d0f095b78ecaae31cad641d343fd80c&page=1
(http://www.vdr-portal.de/board/thread.php?threadid=68215&threadview=0&hilight=&hilightuser=0&sid=2d0f095b78ecaae31cad641d343fd80c&page=1)

Bye
Title: Re: Vomp media player
Post by: toxic-tonic on September 25, 2007, 12:08:04
Thanks I'll try....   ;D
Title: Re: Vomp media player
Post by: avvdr on October 01, 2007, 19:49:15
Hi all,
sorry - have been busy for a while.
Try to give some answers:
1. config file issue
I could imagine to be able to combine entries from both files - i.e. having some of them in the server conf file and some in the client specific ones. Could be done easily.
2. movie play back
Yes - it's one of my prio 1 issues to be done. But still needs some investigations. Could by fairly easy to play mpegs by reusing the recordings player. But first I have to reorganize things a bit. If there is anybody who could give me some hints about the formats the player is able to play (PES, TS,...) and what to consider this would help.
As a second step I would like to create some minimal "framework" on the server side to recode other formats on the fly.
Candidates are:
mencode
gstreamer framework
mediamvp development (was an ongoing discussion there...)
But things are a bit difficult if we would like to have positioning and overall length display...
3. mp3 on windos (@martenR)
It was fairly easy - could just write the mp3 as it was to the device after switching it to the right mode.
My demuxer simply parses the mp3 frames to get the header information and do the positioning stuff.
So it was written from the scratch by following the mpeg specs.
At the end if the parsing fails for some reason it copies the data to the device anyway - hoping that the kernel module can do a better job on it.
If you need further info - please give me some hints how I can help (didn't look at the windows part too much...).

At the end still need some time to make progress...

Regards
Andreas
Title: Re: Vomp media player
Post by: MartenR on October 02, 2007, 07:33:42
to 2.: At the moment PES and TS Playback is possible, but I think it is possible to extent it at the client side to extent to PS as well.
The most important thing would be that you use the draintarget and demuxer mechnismen for feeding the device to be compatible with windows, look into the demuxer code and you will see how the data should be passed.
For ac3 playback, you have to consider a recoding at the server side or client side, if a mvp is connected. The windows port code can/will handle ac3 on its own.
Non mpeg2 data should be recoded at the serverside for the mvp, for the windows port it does not matter

to 3: OK, so the data is passed raw to the device, so have to investigate what the directshow framework wants.
Do you passs the data block by block to the device? Or are you not caring about block boundaries?
Maybe I have to change some parts...

Marten
Title: Re: Vomp media player
Post by: Harry on October 02, 2007, 10:16:43
Quote from: avvdr on October 01, 2007, 19:49:15
Hi all,
sorry - have been busy for a while.
Try to give some answers:
1. config file issue
I could imagine to be able to combine entries from both files - i.e. having some of them in the server conf file and some in the client specific ones. Could be done easily.
[...]
that'd be great.

is it this you have in mind?
global settings in the server conf that are
overridable by settings in the client config.
Title: Re: Vomp media player - broken in cvs
Post by: avvdr on November 18, 2007, 14:54:52
Hello all,
being back in development after long time I found parts of the mediaplayer being broken in current cvs.
Especially the picture viewer did not work well after all the changes in the view/boxx infrastructure.
So I started with bringing the media player back to it's original function first.
As usual you can find the current patches at
http://www.wellenvogel.de/software/vomp/index.html (http://www.wellenvogel.de/software/vomp/index.html).
The patches include an option to run and compile a standalone version of the server part without vdr (especially usefull for testing or for boxes not having vdr at all).
With the patches we should be back to normal functionality now.
Any feedback is highly welcome...

Regards
Andreas
Title: Re: Vomp media player
Post by: Chris on November 18, 2007, 18:11:31
I have applied these patches to cvs, though I haven't done the makefile one yet.

I think I only broke the JPEG banner for the 0.2.7 release (my apologies), the rest should only have broken in recent cvs updates because of the new protocol changes.

Title: Re: Vomp media player
Post by: AndersF on November 26, 2007, 09:17:18
Hi,

The new Media Player functionality is a nice enhancement to the Vomp. It would be nice to be able to use UPNP together with the Vomp.
Is it somehow possible to unpack a dongle so that I can add fusermount/djmount from MVPmc and pack it again?


I would also like to look into the design of Vomp/VDR, are there any good links describing the design, especially the protocol between VDR and VOMP?

Best regards and thanks for the Vomp
Anders
Title: Re: Vomp media player
Post by: avvdr on November 27, 2007, 20:14:47
Hi Anders,
QuoteIt would be nice to be able to use UPNP together with the Vomp
hmm - what would be the use case for it?
vomp has an own limited - but very functional, stable and fast GUI application. How should the UPnP fit into this?
It would require some development effort within the client. A long time ago I tried something with mvpmc - but it was very slow and buggy. For vomp I decided to start going another way. With the current solution we have full control over both the client and server side - and we can freely decide what to do where.
What I'm currently thinking about is to make a small standalone server part (already available in a firts version in the latest patches), that only contains the media player (server) functions and can run without VDR (I've got a DS101j NAS and my goal is to have the server running on this one in the future). So my alternative is:
Compile the server part for your device that has the data (even windows should not be to difficult) - and use VOMP as it is.
QuoteI would also like to look into the design of Vomp/VDR, are there any good links describing the design, especially the protocol between VDR and VOMP
Basics (and the devenev that enables you to create an own dongle - what is quiet simple thanks to Chris's great work) can be found here:
http://www.loggytronic.com/vomp.php (http://www.loggytronic.com/vomp.php)
For the protocol there is not much description there (utf-rts ;) )
If you have any question - just try to ask them here - lots of people will answer...
Regards
Andreas
Title: Re: Vomp media player
Post by: AndersF on November 28, 2007, 09:34:50
Quote from: avvdr on November 27, 2007, 20:14:47

Quotehmm - what would be the use case for it?
One good thing about UPNP is that it is a standard. By using a standard protocol between Set-top box and the server one could use the set-top box without
the need for set-top box specific components on the server.
With the support for UPNP on the Vomp I could use my NAS (Qnap TS-109) as media server without doing anyting on the NAS.
UPNP with its' support for advertising Media servers in the network adds additional flexibility. The Vomp would be able to find several Media servers in the network without the need for configuration of servers' IP addresses. For exampe the NAS could provide my own made films and a MythTV server or VDR the TV shows.

Quotevomp has an own limited - but very functional, stable and fast GUI application. How should the UPnP fit into this?
I got the impression that the Vomp Media player browsed a file system (NFS mounted or locally stored)
If it was then djmount would have made it transparent to Vomp whether UPNP was used or not, since the interface to djmount is the file system.


QuoteWhat I'm currently thinking about is to make a small standalone server part (already available in a firts version in the latest patches), that only contains the media player (server) functions and can run without VDR (I've got a DS101j NAS and my goal is to have the server running on this one in the future). So my alternative is:
Compile the server part for your device that has the data (even windows should not be to difficult) - and use VOMP as it is.
Nice, but then I need to dig into how to add new software to the TS-109, which is supported by NSLUG2 so it is doable.
When I bought my NAS I had the ambition to stay away tweaking it and just use it as it is, since it stores my valuable private films and fotos.


QuoteFor the protocol there is not much description there (utf-rts ;) )
If you have any question - just try to ask them here - lots of people will answer...
Of course the code is there to find out the details. It would be interesting to know high level  information about the protocol, like if it is a binary or a textal protol. TCP or UDP, etc. without digging in to the code.

Regards
Anders
Title: Re: Vomp media player
Post by: muellerph on November 28, 2007, 11:35:39
Quote from: AndersF on November 28, 2007, 09:34:50
Quote from: avvdr on November 27, 2007, 20:14:47
Quotevomp has an own limited - but very functional, stable and fast GUI application. How should the UPnP fit into this?
I got the impression that the Vomp Media player browsed a file system (NFS mounted or locally stored)
If it was then djmount would have made it transparent to Vomp whether UPNP was used or not, since the interface to djmount is the file system.
How about setting up the UPNP protocol on the server plugin? Should also do the trick, but for sure a bit more tricky than on the client.

Vomp client doesn't do any NFS or similar things. Vomp client gets the data directly from the serverplug-in within an own protocol (binary for sure, the client needs to be highly efficient). The server plugin gets the data from the local FS, which could for sure be a mounted NFS directory.
This avoids having a full blown UPNP implementation on the client.

But for sure, some code exists already for the MVPMC (http://www.mvpmc.org/) project (MythTV as server). Similar project, but different codebase. Only some structures are equal.

Till some months ago, we couldn't use UPNP because of the kernel/compiler dependencies, which is now solved (but still patches are needed for the kernel AFAIK). So basically if you want to have a look into code merge from MVPMC there is a starting point.

Code:
The client has a lot of sourcecode, but not the server. As the server is one side of the protocol, it's much easier to look at and find the relevant things.
I don't think it's too much to read and understand (but for sure I didn't do that yet in detail - I'm not working with the protocol stuff).
Title: Re: Vomp media player
Post by: AndersF on November 28, 2007, 14:20:47

QuoteHow about setting up the UPNP protocol on the server plugin? Should also do the trick, but for sure a bit more tricky than on the client.
This would make traffic go from NAS to Media Server and from Media server to MVP. Wasting bandwidth, but maybe functional on 100Mb network.
Another solution would be to run a Media server and UPNP client on localhost. But I guess the Vomp does not support multiple Media servers?

QuoteVomp client doesn't do any NFS or similar things. Vomp client gets the data directly from the serverplug-in within an own protocol (binary for sure, the client needs to be highly efficient). The server plugin gets the data from the local FS, which could for sure be a mounted NFS directory.
This avoids having a full blown UPNP implementation on the client.
Are you sure there is not multiple protocols, like a telnet/text based protocol for listing media files and a binary protocol for the actual media access?
I believe I have seen a telnet interface in the Vomp code!

QuoteBut for sure, some code exists already for the MVPMC (http://www.mvpmc.org/) project (MythTV as server). Similar project, but different codebase. Only some structures are equal.
There are pro's and cons when comparing the two. I would prefer to use one of them. Since I've good experience in using Vomp, the Media player functionality adds momentum to the Vomp solution!

QuoteTill some months ago, we couldn't use UPNP because of the kernel/compiler dependencies, which is now solved (but still patches are needed for the kernel AFAIK). So basically if you want to have a look into code merge from MVPMC there is a starting point.
OK! I will look in to it, but I doubt I will have time to conclude anything useful

QuoteCode:
The client has a lot of sourcecode, but not the server. As the server is one side of the protocol, it's much easier to look at and find the relevant things.
I don't think it's too much to read and understand (but for sure I didn't do that yet in detail - I'm not working with the protocol stuff).
OK Thanks!
Title: Re: Vomp media player
Post by: muellerph on November 28, 2007, 15:28:49
Quote from: AndersF on November 28, 2007, 14:20:47
Another solution would be to run a Media server and UPNP client on localhost. But I guess the Vomp does not support multiple Media servers?
You can have more than 1 vompserver, but need to choose which one you use at then popping up login screen. This is more or less currently only used for development.

QuoteAre you sure there is not multiple protocols, like a telnet/text based protocol for listing media files and a binary protocol for the actual media access?
I believe I have seen a telnet interface in the Vomp code!
I was assuming you meant something like XML transfers. But look at the code, you will see how it is. E.g. you can get a clue here (http://vomp.cvs.sourceforge.net/vomp/vompserver/mvpclient.c?revision=1.53&view=markup).
The client has the busybox telnet implementation.
Title: Re: Vomp media player
Post by: avvdr on November 30, 2007, 17:10:51
Hmm,
interesting discussion...
QuoteI got the impression that the Vomp Media player browsed a file system (NFS mounted or locally stored)
If it was then djmount would have made it transparent to Vomp whether UPNP was used or not, since the interface to djmount is the file system.
OK - would not be too difficult (at least in the moment) to add some code to make the media player also access files on the client side.
Needs some thinking how to be configured - but in the moment it's just 3 functions:
- list a directory
- open a file
- get a block from the file
The more tricky thing would be how to set up the lower layer part.
What I'm afraid of:
If the djmount (didn't deal with it until now) would be slow/ would wait when searching it would block the whole client. When I was using this with mvmpc (and my DS101j which has an UPnP server too) it was really annoying.
@AndersF - if you would like to try something we could make a small interface at the client where code could be plugged in for local file access.
QuoteAre you sure there is not multiple protocols, like a telnet/text based protocol for listing media files and a binary protocol for the actual media access?
I believe I have seen a telnet interface in the Vomp code!
At the end the protocol is all binary.
Just look into vdr.cc on the client side - there you can find all the code.
Basically it's always a (synchronous) request from the client awaiting a response from the server. No parallel transfers in the moment - so you always have to deal with "small" blocks - but this is OK for easy error detection.
QuoteHow about setting up the UPNP protocol on the server plugin? Should also do the trick, but for sure a bit more tricky than on the client.
Would be possible of course - but I would not really like it due to the doubled network load (and again - the same fears) - so maybe this would need separate threads and all the stuff to make it still responsive.
At the end my favorite solution would be some code on the client if we can assure that the vomp will not get blocked from strange things with the media servers...
Currently I'm working on the picture viewer (speed, scaling, colour tunig and exif orientation) - the next will be parallel pictures and audio, then video.
Everything  else (from my side) afterwards.

Regards
Andreas
Title: Re: Vomp media player
Post by: muellerph on November 30, 2007, 21:21:16
Quote from: avvdr on November 30, 2007, 17:10:51
Currently I'm working on the picture viewer (speed, scaling, colour tunig and exif orientation)
This is my favorite and you will be my hero  ;D
Title: Re: Vomp media player
Post by: avvdr on December 02, 2007, 20:24:44
Hello all,
a new version of the media player extensions is available at
http://www.wellenvogel.de/software/vomp/index.html#Update20071202 (http://www.wellenvogel.de/software/vomp/index.html#Update20071202).
It contains improvements for the picture Viewer:
All patches are still against cvs of 2007/11/18, rebase to newest will follow. A dongle is included.

Feedback is highly welcome.
Regards
Andreas
Title: Re: Vomp media player
Post by: Fourty2 on December 03, 2007, 20:10:35
Hi,

maybe you should use a "standard colour-test" picture, as the "DQ-Tool" Image

42
Title: Vomp media player - new version
Post by: avvdr on January 06, 2008, 21:03:26
Hello all,
today I finished a new version of the mediaplayer (basing on current cvs).
The major new features are:

The complete set of patches can be found as usual at:
http://www.wellenvogel.de/software/vomp/index.html#Update20080106 (http://www.wellenvogel.de/software/vomp/index.html#Update20080106)
Any feedback is highly welcome.

Regards
Andreas
Title: Re: Vomp media player
Post by: Harry on January 07, 2008, 07:52:17
hi and thank you for your fine additions!

just out of curiosity:
did you have time to implement this?
Quote from: avvdr on October 01, 2007, 19:49:15
[...]
1. config file issue
I could imagine to be able to combine entries from both files - i.e. having some of them in the server conf file and some in the client specific ones. Could be done easily.
[...]

users always cry for more ;)
cheers
Harry
Title: Re: Vomp media player
Post by: avvdr on January 07, 2008, 11:37:35
Hi Harry,
it's still on the list...
I had to decide whether to release the things I have or not -Holidays are gone now, so time gets limited again...
Prio 1 for me currently is Video.
The cfg file issue is one of the next..

Regards
Andreas
Title: Re: Vomp media player
Post by: hondansx on January 08, 2008, 20:19:34
@avvdr
Quotehttp://www.wellenvogel.de/software/vomp/index.html#Update20080106

a small typo.
To download patch-media-all-cvs080106.txt.gz, I see patch-server-all-cvs080106.txt.gz for download.

Cheers,
Walter
Title: Re: Vomp media player
Post by: avvdr on January 08, 2008, 21:46:44
QuoteTo download patch-media-all-cvs080106.txt.gz, I see patch-server-all-cvs080106.txt.gz for download.

Should be OK now.
Sorry
Andreas
Title: Vomp media player -now video and server side converter
Post by: avvdr on March 21, 2008, 22:16:28
Hello all,
I just finished a new version of the media player, being able to play videos.
Additionally you can insert server side script commands to convert media on the fly.
Please refer to http://www.wellenvogel.de/software/vomp/index.html#Update_20080320 (http://www.wellenvogel.de/software/vomp/index.html#Update_20080320).
Any feedback is highly appreciated.

regards
Andreas
Title: Vomp media player bugfixes/extensions
Post by: avvdr on March 22, 2008, 18:05:20
Hi all,
I just uploaded some bugfixes and extensions for the version 2008/03/20.
Please be aware that there was an error in the documentation for the script interface.
For testing the availability the program is called with the parameter "check".
Files are here:http://www.wellenvogel.de/software/vomp/index.html#Update_080322 (http://www.wellenvogel.de/software/vomp/index.html#Update_080322)

Regards
Andreas
Title: Vomp media player - playlists
Post by: avvdr on April 01, 2008, 07:22:17
Hi all,
I just uploaded some patches to make the media player handle playlists.
This is done via the server side scripting interface. You can now create arbitrary lists via this interface. They are displayed and handled like normal directories.
This also allows for creating lists of streaming sources like internet radio.
Files can be found at
http://www.wellenvogel.de/software/vomp/index.html#Update_20080401 (http://www.wellenvogel.de/software/vomp/index.html#Update_20080401)

Any feedback is highly appreciated.

Regards
Andreas
Title: Vomp media player - patches against 0.2.7
Post by: avvdr on April 04, 2008, 12:48:30
Hi all,
I just uploaded 2 patches that provide the media player functions on top of the 0.2.7 version.
You can find them here
http://www.wellenvogel.de/software/vomp/index.html#Update_20080404 (http://www.wellenvogel.de/software/vomp/index.html#Update_20080404)
Those include the video player functions and the server side script interface to plugin any converters, virtual files,...
Any feedback is welcome.

Regards
Andreas
Title: Re: Vomp media player
Post by: hondansx on April 04, 2008, 15:19:02
Hi Andreas,

BIG THX.  :)
I will give it a try.

Walter
Title: Patch for the 027 version
Post by: avvdr on April 07, 2008, 07:14:55
Hi all,
I just uploaded a small patch that avoids some "unable to load media list" after stopping during playback (audio, video).
Files as usual at
http://www.wellenvogel.de/software/vomp/index.html#Update_20080407 (http://www.wellenvogel.de/software/vomp/index.html#Update_20080407).

Regards
Andreas
Title: Re: Vomp media player
Post by: tivi on April 17, 2008, 18:40:55
Hi Andreas,

I would like to use your latest patch. I'm using the diff listed here:
http://www.vdr-portal.de/board/thread.php?threadid=69824&threadview=0&hilight=&hilightuser=0&page=1 (http://www.vdr-portal.de/board/thread.php?threadid=69824&threadview=0&hilight=&hilightuser=0&page=1).

Unfortunately compiling stops with error.

make[1]: Entering directory `/usr/src/vdr/vdr-1.4.7/PLUGINS/src/vompserver'
( if [ -f .standalone ] ; then ( rm -f .standalone; make clean ; make objects ) ; else exit 0 ;fi )
g++ -O2 -fPIC -Wall -Woverloaded-virtual -Werror -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"vompserver"' -DVOMPSERVER -I../../../include -I/include -o media.o media.c
media.c: In member function `char* Media::getTimeString(char*) const':
media.c:238: Warnung: »%g« liefert nur die letzten 2 Ziffern des Jahres
make[1]: *** [media.o] Fehler 1


Compiling without applying the patch works.

Any ideas?

Regards
tivi
Title: Re: Vomp media player
Post by: avvdr on April 17, 2008, 20:13:59
Hi tivi,
which gcc you are using?
Looks like -Wformat-y2k is enabled (that should be disabled by default).
Cannot try it in the moment, but maybe adding -Wno-format-y2k to CXXFLAGS in the Makefile works.
Alterantively you could go the hard way with omitting -Werror in CXXFLAGS as a workaround.

Regards
Andreas
Title: Re: Vomp media player
Post by: tivi on April 17, 2008, 23:27:02
Hi Andreas,

THX for posting. Meanwhile Alex told me to change line 238 in media.c:

strftime(buffer,TIMEBUFLEN, "%0G/%0m/%0d %0H:%0M ", btime);


That works!


Regards
tivi
Title: Re: Vomp media player
Post by: stu-e on April 26, 2008, 01:37:27
Hi Andreas
I get an error when building vompserver with your latest media patches:
cc1plus: warnings being treated as errors
medialauncher.c:75: warning: deprecated conversion from string constant to 'char*'
medialauncher.c:75: warning: deprecated conversion from string constant to 'char*'
medialauncher.c:75: warning: deprecated conversion from string constant to 'char*'
medialauncher.c:75: warning: deprecated conversion from string constant to 'char*'
make[1]: *** [medialauncher.o] Error 1

I edited the assignment to mediatypes as follows:
static struct {
  char* mtypename;
  ULONG mtypeid;
} mediatypes[]= {
  {(char *) "PICTURE",MEDIA_TYPE_PICTURE},
  {(char *) "AUDIO",MEDIA_TYPE_AUDIO},
  {(char *) "VIDEO",MEDIA_TYPE_VIDEO},
  {(char *) "LIST",MEDIA_TYPE_DIR}
};

Now it builds without error.

Stuart
Title: Re: Vomp media player
Post by: avvdr on April 29, 2008, 20:19:38
Hi Stuart,
which gcc are you using?
Most probably changing

char* mtypename
to
const char* mtypename

could solve the problem (without the ugly casts  :( )- but I'm not sure (it will maybe need some other const's in the code.
Is the only reason I see why gcc should warn here - assigning a const string to an non const ptr...

Regards
Andreas
Title: Re: Vomp media player
Post by: stu-e on April 30, 2008, 09:36:06
Gcc 4.2

I'll try const instead of the cast and let you know if it compiles ok or not.

Stuart
Title: Re: Vomp media player
Post by: stu-e on May 01, 2008, 09:39:00
Yes gcc 4.2 compiles ok using const char* instead of the casts.

Thanks
Stuart
Title: Re: Vomp media player
Post by: avvdr on May 01, 2008, 18:32:46
QuoteYes gcc 4.2 compiles ok using const char* instead of the casts.

OK - will change this in the code.

Regards
Andreas
Title: Re: Vomp media player
Post by: stu-e on May 29, 2008, 23:51:55
I just tried to play some mp3s encoded using the LAME nogap feature for gapless playback.
There is still a gap between tracks that would normally have no gap between them.
The tracks however play gapless using Xine.

Any chance Vomp Media Player can support gapless mp3 playback?
Title: Mediiaplayer > CVS
Post by: keynet on June 01, 2008, 12:15:21
Hi Andreas,

I'd like to build your new mediaplayer because the one in CVS is broken at the moment (when you exit playback, MVP crashes).
I know Chris has made quite a few changes recently.
Could you possibly commit your latest mediaplayer code to CVS so I can build it / test it / keep track of changes?
It will help all the users to test/feedback bugs

Thanks!
Title: Re: Vomp media player
Post by: Chris on June 01, 2008, 22:06:21
Hi keynet, Andreas,

I found a bug causing vomp to lock up when pressing back from an mp3. It was caused by my new gui code so I have applied a fix to the version in CVS.
Title: Re: Vomp media player
Post by: muellerph on June 02, 2008, 16:05:52
I think the same issue is when displaying a JPEG.

After <back> on a displayed JPEG image the box hangs.

MP3 works with <back>
Title: Re: Vomp media player
Post by: avvdr on June 03, 2008, 05:54:13
Hi keynet,
no chance for me to submit to cvs - as I have no write access.
During summer there is only little time for me to work on following all the changes in cvs with my patches - so still needs some time.
Currently you can try the extended 0.2.7 version provided by Alex at VDR portal:
http://www.vdr-portal.de/board/thread.php?threadid=69824&hilight=vomp (http://www.vdr-portal.de/board/thread.php?threadid=69824&hilight=vomp)

At least when I released my latest patches I tested them against the cvs at this time...

Regards
Andreas
Title: Re: Vomp media player
Post by: keynet on June 03, 2008, 11:22:04
Thanks Andreas. 
Unfortunately this version doesn't work with latest cvs.  Oh, and it's in German  :-\
Which version (e.g. cvs date) of the vompserver plugin is the dongle built for?

Chris - Would you consider giving Andreas write access to help development?
His contributions are really valuable.
Title: Re: Vomp media player
Post by: keynet on June 04, 2008, 19:15:55
Quote from: Chris on June 01, 2008, 22:06:21
Hi keynet, Andreas,

I found a bug causing vomp to lock up when pressing back from an mp3. It was caused by my new gui code so I have applied a fix to the version in CVS.

Chris thanks for the fix. 
Unfortunately when I todays latest cvs client + server it still crashes on exit from playing either a jpg or mp3  :(
The only thing I can think of is that I don't have the translation files in plugins/vompserver/ - do I need them if I'm just running English, if so where can I find them?
Title: Re: Vomp media player
Post by: muellerph on June 04, 2008, 20:39:05
If there aren't any translation files, you just won't be able to select any language other than english.
So this is not the issue.
Title: Re: Vomp media player
Post by: avvdr on June 05, 2008, 19:52:39
Hi keynet,
QuoteUnfortunately this version doesn't work with latest cvs.  Oh, and it's in German

- yes the 0.2.7.xx provided by Alex at vdrportal is somehow an own branch. Unfortunately there is a lot of changes Chris introduced in the protocol afterwards - so there is only the option to use both client and server from vdr portal. Anyway the forum is in german - but the vomp is still in english...(I guess you would even get some help there in english) - from my pov currently the most stable version. At least we also added a small patch that should prevent a couple of freezes in playbacks (especially when pressing a key while waiting for data).
- for the cvs/LATEST I'm afraid there is not much time currently on my side (and to be honest I would like to wait for some stable version because it's a lot of effort to follow all the changes with my patches)

I guess a valuable solution would be branches in the cvs (was already discussed in some other thread) - but this depends on Chris.

So - for the moment sorry - but no better solution available.

Regards
Andreas
Title: Re: Vomp media player
Post by: rdoac on June 16, 2008, 08:17:06
I'm playing with this at the moment.  I have succeeded in getting vdr playing avi's and am almost happy.

However, I have changed test1.sh slightly to fill the screen with the avi:



#convert AVI to mpeg2, suing mencoder see
#http://www.wiki.csoft.at/index.php/MEncoder_Scripts
convertAVI() {
mencoder -oac copy -ovc lavc -of mpeg -mpegopts format=dvd:tsaf \
  -vf scale=720:576,harddup -ofps 25 \
  -lavcopts vcodec=mpeg2video:vrc_buf_size=1835:vrc_maxrate=9800:vbitrate=5000:\
keyint=15:vstrict=0:aspect=16/9 \
$RTOP -o $FIFO "$1" > /tmp/mencoder.out 2>&1 &
  MPID=$!
}



However on my Sempron 3000 I am getting stuttering.  As root I need to renice mencoder to 15.  Am trying to find a way to run the mencoder with a nice priority of -10 or so.  I know the pc could become sluggish during this but I can live with it.  Any ides?
Title: Re: Vomp media player
Post by: keynet on June 18, 2008, 00:22:53
Quote from: avvdr on June 05, 2008, 19:52:39
--snip --
I guess a valuable solution would be branches in the cvs (was already discussed in some other thread) - but this depends on Chris.

So - for the moment sorry - but no better solution available.

Regards
Andreas

Thanks Andreas. 
I tried the Yaris patch & dongle and got it to compile with VDR 1.6, seems to work well.
I found one problem though - the WSS (wide screen switching) doesn't seem to work any longer - at least on playback of recordings - an old 4:3 format recording is always shown widescreen.  The current version (and older official versions of VOMP) this function works.
Thanks for the good work - I look forward to seeing it integrated.
Title: Re: Vomp media player
Post by: hondansx on June 18, 2008, 17:14:22
Hi Keynet,

which dongle are u using?
The prefered one is vomp-dongle-0.2.7-6.1-Yaris.tar.gz

Bye,
Walter
Title: Re: Vomp media player
Post by: keynet on June 18, 2008, 18:56:51
Walter,
I'm using the 16x9 version (vomp-dongle-0.2.7-16x9-6.1-Yaris.tar.gz) because I assumed that was right for a 16x9 widescreen TV?
What's the difference between this and vomp-dongle-0.2.7-6.1-Yaris.tar.gz?
Thx
Title: Re: Vomp media player
Post by: avvdr on June 18, 2008, 20:54:23
Hi rdoac,
QuoteAm trying to find a way to run the mencoder with a nice priority of -10 or so
Maybe just a setuid shell script (or executable) that wraps mencoder and "nices" before really starting it.
There is taht many options to mencoder - maybe we can find something provding sufficient quality by lower CPU usage (would be even great to have some automatic choosing of the right parameters depending on CPU...).

Regards
Andreas
Title: Re: Vomp media player
Post by: hondansx on June 18, 2008, 21:37:11
@Keynet,

QuoteWhat's the difference between this and vomp-dongle-0.2.7-6.1-Yaris.tar.gz?

0.2.7-16x9-6.1 is only for 16x9 widescreen TV and forces all Channels and Playbacks to 16:9,
which will  fill the screen in every situation. ;D
In less situations, where 4:3 Material is to bad for 16:9, this can be controlled over the remotecontrol by TV.
Otherwise here in Germany there are too much broadcasters, who send all the time in 4:3 Format.

@rodac

QuoteHowever on my Sempron 3000 I am getting stuttering.

You can try to downscale, maybe
.... -vf scale=352:288,harddup -ofps 25 ...


Bye,
Walter

Title: Re: Vomp media player
Post by: rdoac on June 19, 2008, 12:25:31
Quote from: avvdr on June 18, 2008, 20:54:23
Hi rdoac,
QuoteAm trying to find a way to run the mencoder with a nice priority of -10 or so
Maybe just a setuid shell script (or executable) that wraps mencoder and "nices" before really starting it.
There is taht many options to mencoder - maybe we can find something provding sufficient quality by lower CPU usage (would be even great to have some automatic choosing of the right parameters depending on CPU...).

Regards
Andreas

I though of that, but I still get a permission denied, to setuid you make the user root and chmod +s the script right?

Anyway, I'm playing with "verynice" and have added mencoder to the list of programs which need high nice values.  It takes  a minute or so, then kicks in.
Title: Re: Vomp media player
Post by: Uatschitchun on October 07, 2008, 13:57:09
Hi there  :D

First I like to give thx for the mediaplayer !!! I couldn't live without it! How else could I hear "???" for to fall asleep  :P

I now tried the newest version (0.2.7-6.1) with videos ... and I've got a few questions:

1.)
Videos in
QuoteMPEG sequence, v2, program multiplex
running well  :D

But what about vids in:
QuoteMPEG sequence, v1, system multiplex
???

These are running, but I have no sound ?!
Do I need a new converter therefor?

2.)
Some AVIs are displayed too high (like pic-black-black, instead of black-pic-black)?! How do I get these displayed correctly?

3.)
What is the difference between "letter" and "clipfactor" for pictures? They look the same?!

Thx for this great extension and for helping me out!
Roman
Title: Re: Vomp media player
Post by: avvdr on October 07, 2008, 20:00:45
hi,
hmm I try to answer.
1). Mpeg1 - anything strange could be most probably played with converting it via mencoder. In the moment the easiest way would be to try to find out how mencoder could covert your stuff into mpeg2, then name all your files e.g. xyz.mpg1 and define a command to be executed for mpg1 in the config file (see some hints here above or in the vdr forum).
2.) still a bug there in the player (maybe could be fixed with some nice mencoder options too...)
3.) letter and clipfactor are a bit different:
see readme_media.txt:
QuoteYou can select 3 different modes for the picture - "letter" - always completely on screen,
  "crop" always cropped by next possible scale and "croppercent" - you can select the Picture Size
  within the option page from 10%...150% - the picture gets scaled to best fit to the screen within
  this range.

Regards
Andreas
Title: Re: Vomp media player
Post by: Uatschitchun on October 08, 2008, 09:25:26
Oki, thx ... thought these would be your answers  ;D

1.)
Someone able to provide a mencoder call for to convert mpeg1 to mpeg2?

2.)
Is there still development planed to get this bug in the player fixed?
How could the mencoder call be modified to get a workaround?

What about wmv? Someone got a mencoder call on this?

Am I the only one that has more formats than just mpeg2?
Maybe we could collect the converters for various formats somewhere?

Lg
Roman
Title: Re: Vomp media player
Post by: hondansx on October 08, 2008, 16:37:46
@avvdr

Is there any chance to get your media part working on the current vomp version?
Would be very nice  :)

Bye,
Walter
Title: Re: Vomp media player
Post by: avvdr on October 11, 2008, 16:06:17
Hi Walter,
yes I will port back to current version.
It's getting colder outside now, so there will be time in the near future to continue hacking a bit.
I will have a look at the position issue (most probably easy to fix).

Regards
Andreas
Title: Re: Vomp media player
Post by: rdoac on November 12, 2008, 18:23:10
Is there anywhere to send Beer etc to encourage the development process along? :->
Title: Re: Vomp media player
Post by: Sir George on November 19, 2008, 18:24:15
Quote from: rdoac on November 12, 2008, 18:23:10
Is there anywhere to send Beer etc to encourage the development process along? :->
Good idea! I'm willing to donate, too. Paypal, postbox, anything?  :)
Title: Re: Vomp media player
Post by: avvdr on November 30, 2008, 21:35:45
Hello all,
today I finished porting the latest media player stuff to the current CVS (as of 2008/11/28).
This includes:
Unfortunately the internal handling of views has a lot of changes that caused a couple of deadlocks - so I had to add some lock/unlock there.
Files can be found at www.wellenvogel.de/software/vomp#Update_20081130 (http://www.wellenvogel.de/software/vomp#Update_20081130).
Feedback is highly appreciated.
Would be really great if the stuff could go to CVS in the near future - it's a lot of effort to always port things...

Regards
Andreas
Title: Re: Vomp media player
Post by: avvdr on December 14, 2008, 17:50:17
Hi all,
just added some small additions (bug fixes) and improvements for the server side converter.
See http://www.wellenvogel.de/software/vomp/index.html#Update_20081214 (http://www.wellenvogel.de/software/vomp/index.html#Update_20081214).
The patches do also include some stability patches for the live tv viewer (especially for high bandwith channels like german "Das Erste").

Regards
Andreas
Title: Re: Vomp media player
Post by: avvdr on December 14, 2008, 22:50:15
Hello all,
second update for today:
Vomp can now play dvd's and iso images via the server side scripts (mencoder).
For details seehttp://www.wellenvogel.de/software/vomp (http://www.wellenvogel.de/software/vomp)

Regards
Andreas
Title: Files > 2GB
Post by: avvdr on December 22, 2008, 11:21:44
Hi all,
I just released a patch to be able to correctly play files > 2GB.
For details refer to http://www.wellenvogel.de/software/vomp/index.html#Update_20081222 (http://www.wellenvogel.de/software/vomp/index.html#Update_20081222)
Regards
Andreas
Title: Re: Vomp media player
Post by: davep on December 25, 2008, 21:23:31
I see the Media Player has appeared in CVS. Unfortunately it doesn't work for me. When I navigate to a directory containing .jpg files and select one, the screen blanks and the MVP has to be power-cycled. If I do the same with a .mp3 file the music plays but again the screen blanks and the only way to regain control is the power switch.

This is the debug output when viewing a JPEG file:

21:12:24.134112 [debug]  50 VMediaList - show picture file P7210031.JPG
21:12:24.135072 [debug]  50 VMediaView::createViewer - p=0x1023c198
21:12:24.135895 [debug]  50 Boxx - Construct, now 7
21:12:24.136628 [debug]  50 VMediaView::VMediaView - p=0x10240620
21:12:24.137610 [debug]  50 ImageReader - ctorI
21:12:24.204858 [debug]  59 ImageReader - player thread started
21:12:24.271379 [debug]  50 MediaOptions - option value for FactorRed is 100
21:12:24.272103 [debug]  50 MediaOptions - option value for FactorGreen is 100
21:12:24.273032 [debug]  50 MediaOptions - option value for FactorBlue is 100
21:12:24.273752 [debug]  50 VColourTuner - setting initial factors r=100,g=100,b=100
21:12:24.319356 [debug]  50 MediaOptions - option value for SlideShowInterval is 5
21:12:24.320110 [debug]  50 MediaOptions - option value for ScaleFactor is 1
21:12:24.320919 [debug]  50 MediaOptions - option value for PictureMode is clip
21:12:24.321724 [debug]  50 MediaOptions - option value for PictureSize is 90
21:12:24.322683 [debug]  50 BoxStack - Locked for add
21:12:24.323499 [debug]  50 BoxStack - Unlocked for add
21:12:24.324172 [debug]  50 VMediaView::draw - pictureError=(null),p=0x10240620
21:12:24.325162 [debug]  50 BoxStack - Locked for update
21:12:24.326046 [debug]  50 BoxStack - Unlocked for update
21:12:24.326881 [debug]  50 VMediaView - set pictureMode 1 p=0, a=0
21:12:24.327566 [debug]  50 Timers - Starting cancel timer 0x10240664 2, list size = 1
21:12:24.328521 [debug]  50 BoxStack - Locked for update
21:12:24.329321 [debug]  50 BoxStack - Unlocked for update
21:12:24.329993 [debug]  50 BoxStack - Locked for update
21:12:24.436964 [debug]  50 BoxStack - Unlocked for update
21:12:24.437649 [debug]  50 BoxStack - Locked for update
21:12:24.438440 [debug]  50 VMediaView::draw - pictureError=(null),p=0x10240620

MVP is a model D3 with the 'old' remote, and VDR is 1.6.0-2.
Title: Re: Vomp media player
Post by: avvdr on December 26, 2008, 12:45:43
@davep,
QuoteI see the Media Player has appeared in CVS. Unfortunately it doesn't work for me. When I navigate to a directory containing .jpg files and select one, the screen blanks and the MVP has to be power-cycled. If I do the same with a .mp3 file the music plays but again the screen blanks and the only way to regain control is the power switch.

Unfortunately Chris did not integrate some of the most important changes to boxxstack.cc.
I attach a patch here, that contains the still necessary changes to boxstack.cc - maybe you can try it out.

Regards
Andreas

Title: Re: Vomp media player
Post by: davep on December 26, 2008, 14:08:22
Yes that now works, many thanks.

Can anything be done about the aspect ratio of images? If I display images taken from film transparencies (3:2 aspect ratio), they appear on the screen stretched into the 16:9 format. For landscape photos this doesn't look too bad, but portrait photos appear nearly square.

Also fast-forward mode is enabled when playing mp3 files. This makes a terrible noise!
Title: Re: Vomp media player
Post by: MartenR on December 26, 2008, 14:44:42
@avvdr
I tried today  to make it compile under windows and I am wondering, why mediafile.cc accesses the lokal filesystem.
Can you explain me what it does?
At the moment it makes no sense for me to access the dongle file system.
(Btw under windows I cannot integrate any type of network file system only the vomp protocoll is used).
Title: Re: Vomp media player
Post by: avvdr on December 26, 2008, 20:49:52
@MartenR
QuoteI tried today  to make it compile under windows and I am wondering, why mediafile.cc accesses the lokal filesystem.
Can you explain me what it does?
At the moment it makes no sense for me to access the dongle file system.

Basicall the media player infrastructure is somehow generic.
This way it is also possible to access media files locally at the dongle. The basic intention for this was to e.g. enable upnp access to media servers. I did not really work on this intensively in the past - but in general it works.
If this is a problem on windows, just omit registering the local file access functions on windows (skip registering the mediaprovider in ctor localmediafile.cc).
I guess to make it working on windows it would need some changes to deal correctly with the / -> \ issue.

regards
Andreas
Title: Re: Vomp media player
Post by: avvdr on December 26, 2008, 20:55:24
@davep
QuoteCan anything be done about the aspect ratio of images? If I display images taken from film transparencies (3:2 aspect ratio), they appear on the screen stretched into the 16:9 format. For landscape photos this doesn't look too bad, but portrait photos appear nearly square.
Do you have an example for me?
Not really sure what to do there - I use the settings the menu is in for displaying pictures. Maybe for 16:9 this needs some changes.
It would be helpfull if somebody could give me some hints how it should look like on 16:9 tvs (mine is currently 4:3 ;-().
QuoteAlso fast-forward mode is enabled when playing mp3 files. This makes a terrible noise!
I agree - the only short term solution would be sto disable this.
Maybe somebody knows how to do frame skipping for ff to make it sounding "acceptable"...

regards
Andreas
Title: Re: Vomp media player
Post by: davep on December 27, 2008, 10:11:52
Quote from: avvdr on December 26, 2008, 20:55:24
Do you have an example for me?
Not really sure what to do there - I use the settings the menu is in for displaying pictures. Maybe for 16:9 this needs some changes.
It would be helpfull if somebody could give me some hints how it should look like on 16:9 tvs (mine is currently 4:3 ;-().

I've taken some photos of my TV screen - apologies for the quality!

http://www.zen7209.zen.co.uk/p1.jpg
This is a scan from 35mm film (3:2 aspect ratio) in portrait mode. The original is 1608x2421 pixels.

http://www.zen7209.zen.co.uk/p2.jpg
A 35mm film scan in landscape, originally 2406x1614 pixels

http://www.zen7209.zen.co.uk/p3.jpg
A digital camera photo (4:3 aspect ratio) landscape 2048x1536 pixels

http://www.zen7209.zen.co.uk/p4.jpg
A digital photo in portrait, 1536x2048 pixels.

My Vomp media settings are:
Picture Mode: Clipfactor
Scale Factor: 1
Size: 100%
Title: Re: Vomp media player
Post by: rdoac on December 27, 2008, 13:15:50
Hmm, a small point.  It can't seem to play avi files with the latest test1.sh file with spaces in the name.  The previous (or maybe mine) one could.
Title: avis with spaces
Post by: avvdr on December 27, 2008, 20:58:42
@rdoac,
just uploaded a patched script at http://www.wellenvogel.de/software/vomp (http://www.wellenvogel.de/software/vomp).

Thanks for the hint..
Regards
Andreas
Title: pictures on 16x9
Post by: avvdr on December 27, 2008, 21:34:28
@davep,
thanks for the examples...
But maybe the problem is still not really clear to me.
Do you run on 16:9 (I guess yes).

What I feel:
If you run everything in 16:9 the pixels are not really square anymore (as assumed for 4:3).
At the end we output still 720x576 (for PAL) but in reality it goes to somewhat like 1024x576 so in horizontal direction every pixel is expanded by 1.4.

If you want to try something and if you are running the latest version and have picture display via test1.sh enabled, you could make some replacements in test1.sh:
around lines 236ff (in convertPicture.sh):

238: fopt="-geometry 1024x$3"
...
245: gm convert $rtopt $fopt  "$1" jpeg:- | gm convert -geometry '70%x100%!' jpeg:- jpeg:- 2>&1 &

And see how this looks like...
If this is OK, I have to figure out, how I could do this scaling on the vomp side.
Alternatively we could switch picture display to 4:3 (but then it depends on your TV).

Regards
Andreas
Title: Re: Vomp media player
Post by: davep on December 27, 2008, 21:46:40
Quote from: avvdr on December 27, 2008, 21:34:28
Do you run on 16:9 (I guess yes).

The TV aspect ratio is set by VOMP (using WSS) so maybe the best way is to force the TV to 4:3 when using media player. This will be correct for digital cameras. The best that can be done for portrait photos is if the pictures use all of the available screen height.
Title: Re: Vomp media player
Post by: avvdr on December 28, 2008, 15:33:37
@davep
QuoteThe best that can be done for portrait photos is if the pictures use all of the available screen height.
If you display jpegs via the converter (test1.sh) it tries to fit the picture to the screen the best it can by keeping the ratio.
I'm still investigating if there is an easy way to do this at the mvp...

Regards
Andreas
Title: Re: Vomp media player
Post by: AxelAhrens on January 04, 2009, 12:18:42
hello, great that the vomp now can play videos and dvds. My problem is that i don´t know how i have to update my mahlzeit vdr with vomp ?

Can anybody help me ?


greets Axel
Title: Vomp media player - missing stuff
Post by: avvdr on January 17, 2009, 17:16:37
Today I checked the cvs for media player stuff that is still missing.
I attach 2 patches here - one for the missing corrections in the mediaplayer, the other one for the tcp stuff.
Additionally there are still some missing changes in boxstack.cc - I also attach a patch here - not all of it is really necessary, but at least it creates a working version.

Regards
Andreas
Title: Re: Vomp media player - missing stuff
Post by: davep on January 18, 2009, 09:55:06
Quote from: avvdr on January 17, 2009, 17:16:37
Today I checked the cvs for media player stuff that is still missing.
I attach 2 patches here - one for the missing corrections in the mediaplayer, the other one for the tcp stuff.

After applying the patches I get these compilation errors:

playermedia.cc: In member function `virtual void PlayerMedia::timercall(int)':
playermedia.cc:650: error: 'class DemuxerMedia' has no member named 'getLastDemuxerPTS'

playermedia.cc: In member function `ULLONG PlayerMedia::getBytesPerSecond()':
playermedia.cc:774: error: 'class DemuxerMedia' has no member named 'getLastDemuxerPTS'

make: *** [playermedia.o] Error 1
Title: Re: Vomp media player
Post by: avvdr on January 18, 2009, 10:35:30
Sorry - I forgot the demuxermedia...
Attached here.
Regards
Andreas
Title: Re: Vomp media player
Post by: davep on January 18, 2009, 11:27:08
Now I get:

demuxermedia.cc: In member function `void DemuxerMedia::parseVDRPacketDetails()':
demuxermedia.cc:295: error: 'class PESPacket' has no member named 'duplicateHeader'
Title: Re: Vomp media player
Post by: avvdr on January 19, 2009, 12:09:13
sorry - currently not really much time to check...
Please do simply omit the call to duplicateHeader in demuxermedia.cc (not really critical for functionality).

regards
Andreas
Title: Re: Vomp media player
Post by: Lutz on August 03, 2009, 16:28:51
@avvdr:

Hi Andreas,

I'm trying out your media player (Vomp 0.3.1), it works in parts:
I can play mpeg2 videos, but some without sound.
I can play avi's, but they don't fill the screen, they are quarter of size or so..
Isos: If I select an iso file, I get a black screen for some 20 seconds, then back the menu.

Do you have any hints for me? Especially the possibility to replay dvd iso files would be nice to have...

Thank you for your nice work!

Lutz

P.S.: ...Vomp for Windows doesn't replay any of the above
Title: Re: Vomp media player
Post by: avvdr on August 10, 2009, 19:37:19
@Lutz,
which version do you use? cvs?
I would suggest to goto vdr portal and use this version - probably the cvs is still not on the latest version.
http://www.vdr-portal.de/board/thread.php?threadid=79474&hilight=vomp (http://www.vdr-portal.de/board/thread.php?threadid=79474&hilight=vomp)

Sorry for this - but I cannot write to cvs and have to wait until Chris merges everything...
If things still not work, logs would be interesting - client and server (a lot is discussed at the vdr portal thread - although in german).

Regards
Andreas
Title: Re: Vomp media player
Post by: AndersF on August 11, 2009, 05:37:28

Quote from: Lutz on August 03, 2009, 16:28:51
Do you have any hints for me? Especially the possibility to replay dvd iso files would be nice to have...

Have you installed lsdvd?

To enable mediaplayer on ubuntu 9.04 I had to do:

sudo apt-get install lsdvd
sudo apt-get install mencoder
sudo apt-get install lame
sudo apt-get install ffmpeg

I can play ISO's, but not avi's though.

/Anders
Title: Re: Vomp media player
Post by: Harry on August 11, 2009, 17:18:25
Quote from: Harry on January 07, 2008, 07:52:17
hi and thank you for your fine additions!

just out of curiosity:
did you have time to implement this?
Quote from: avvdr on October 01, 2007, 19:49:15
[...]
1. config file issue
I could imagine to be able to combine entries from both files - i.e. having some of them in the server conf file and some in the client specific ones. Could be done easily.
[...]

users always cry for more ;)
cheers
Harry

hi Andreas and all,

it seems that at least in dongle 0.3.1 the [media] section is not honoured in the individual
mvp conf files :-(.
am i missing something?

cheers
Harry
Title: Re: Vomp media player
Post by: Harry on August 18, 2009, 07:14:42
anyone?
Title: Re: Vomp media player
Post by: avvdr on September 02, 2009, 19:55:52
after long time:
sorry: unfortunately client specific configs are still not there...

Regards
Andreas
Title: Re: Vomp media player
Post by: Harry on September 02, 2009, 21:59:17
no problem.

i'll annoy you every now and then with this, though ;)

cheers
Harry