Loggytronic Forum

VOMP => VOMP General / MVP => Topic started by: ravageng on July 23, 2006, 15:41:53

Title: PATCH: play radio recordings with current cvs
Post by: ravageng on July 23, 2006, 15:41:53
Hello,

currently replaying radio recordings seems to be broken. Vomp-clients tries to seek the video contents - which must fail.

So changing demuxer.cc (about line 115) into:

void Demuxer::seek()
{
  if (audio_current != -1)
  {
    aud_seeking = true;
    audio_pts = 0;
  }
  if (video_current != -1)
  {
    vid_seeking = true;
    video_pts = 0;
  }
}

solves playing audio only streams for me.

Beside that it would be nice if vomp would display the correct time information on the OSD (so also jumping by seconds/minutes would work). Also very, very nice would be a still image when listing radio streams.

Best regards and thanks for this nice piece of software!
Title: Re: PATCH: play radio recordings with current cvs
Post by: MarkC on July 24, 2006, 13:05:36
Well spotted - thanks for reporting the problem.
I think your patch would work fine but actually Chris and I agreed that the player should only call seek() for video playback. Seeking doesn't make sense with radio because the purpose of seek() is to find a video I-frame.

We handled this correctly for live playback but not, it seems, for recordings. We'll have it fixed in CVS pretty soon.

Mark