Hi,
don't know whether this is the right one, but no it compiles.
--- videomvp.h.orig 2012-11-07 21:17:54.337130080 +0100
+++ videomvp.h 2012-11-07 21:19:31.177881883 +0100
@@ -22,6 +22,7 @@
#ifndef VIDEOMVP_H
+#endif
#define VIDEOMVP_H
// FIXME - check why so many things include unistd
@@ -110,7 +111,7 @@
UCHAR getSupportedFormats() { return COMPOSITERGB | SVIDEO;};
UINT supportedTVsize() { return ASPECT4X3|ASPECT16X9;};
- UCHAR supportedTVFormats() { return 0;}; /* We cannot change this here
+ UCHAR supportedTVFormats() { return 0;}; // We cannot change this here
int setFormat(UCHAR format);
int setConnection(UCHAR connection);
@@ -156,4 +157,3 @@
UINT mediapacket_len[WRITE_PACKETS];
};
-#endif
Hi,
I have not check this, but in my mind, the "#endif" must be at the end of the document and it already exists there.
Claus
@hondansx
Thanks for the fix will go into git. But as clausmuus pointed out the endif is wrong.
Marten
Quote from: MartenR on November 08, 2012, 06:50:59
@hondansx
Thanks for the fix will go into git. But as clausmuus pointed out the endif is wrong.
Marten
This was intended, because I assume that the '#ifndef VIDEOMVP_H' is also wrong or not needed
.
Quote'#ifndef VIDEOMVP_H
is very important, it prevents that spurious compiler warnings occur, if you include a header file multiple times.
Marten